GithubHelp home page GithubHelp logo

Comments (6)

etrepum avatar etrepum commented on July 28, 2024

It seems like the representation here should change to be more similar to how it is in Python's AST

expr = …
         | ListComp(expr elt, comprehension* generators)
         | SetComp(expr elt, comprehension* generators)
         | DictComp(expr key, expr value, comprehension* generators)
         | GeneratorExp(expr elt, comprehension* generators)
         | …

comprehension = (expr target, expr iter, expr* ifs)

from mypy.

etrepum avatar etrepum commented on July 28, 2024

An additional bug here is that only at most one if is allowed

from mypy.

JukkaL avatar JukkaL commented on July 28, 2024

See this commit by Eric Price: d3ce840

from mypy.

etrepum avatar etrepum commented on July 28, 2024

Ah, didn't realize there was work happening on a branch. I don't think this fixes #324 but might have a conflict. Is this getting merged any time soon? I can rebase when that happens.

from mypy.

JukkaL avatar JukkaL commented on July 28, 2024

I'm probably going to merge the branch later today, assuming I don't find any critical bugs. I'll write a comment when it happens.

from mypy.

JukkaL avatar JukkaL commented on July 28, 2024

This was just merged. Closing the issue.

from mypy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.