GithubHelp home page GithubHelp logo

Comments (3)

JelleZijlstra avatar JelleZijlstra commented on June 14, 2024 1

Agree, there's no need for mypy_extensions.TypedDict any more. As an implementation strategy, we can:

  • Raise a runtime DeprecationWarning when a new mypy_extensions.TypedDict class is created
  • Have mypy show a warning whenever mypy_extensions.TypedDict is used

from mypy_extensions.

AlexWaygood avatar AlexWaygood commented on June 14, 2024

I'm taking a look at the runtime side of things. One issue: it seems we'd really need stacklevel=3 if you're constructing a TypedDict class like this:

Foo = TypedDict('Foo', {'x': int})

...But you'd need stacklevel=2 if you're constructing a TypedDict like this:

class Bar(TypedDict):
    x: int

I'm not sure if there's a way to distinguish between the two, if we emit the DeprecationWarning in _TypedDictMeta.__new__

from mypy_extensions.

AlexWaygood avatar AlexWaygood commented on June 14, 2024

I'm not sure if there's a way to distinguish between the two, if we emit the DeprecationWarning in _TypedDictMeta.__new__

Hmm, I think I have a solution

from mypy_extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.