GithubHelp home page GithubHelp logo

Comments (5)

MarshallPeng avatar MarshallPeng commented on July 29, 2024 1

I would be careful with using this in a real environment. I think the author made a mistake with the way he sets his prices. For example, he sets current price to the open price.

current_price = self.df.loc[self.current_step, 'Open']

This means that the agent is able to look ahead in time, as the agent is also aware of the close price for the same timestep, but is still able to execute at the open price. This is a form of lookahead bias; the agent might simply look at the open price, see that the close is higher and then choose to buy. In real life, you wouldn't know the close until after that time period has passed.

So although the work that he does is really cool and impressive, it will likely not beat the market in a real trading situation.

from rl-bitcoin-trading-bot.

pythonlessons avatar pythonlessons commented on July 29, 2024 1

is abandon project ,no binance implementation is posible

The point was to provide a tutorial, and he did that. I'm not sure why you were expecting a fully useable implementation. This is open source, make the interface yourself in a fork.

Thanks for a good word. Yes, I created these tutorials not to risk everyone's money and let it make profitable trades out of the box. It's far from the stage where we could be using it in the real market. And if someday I will think about doing a public bot to make these trades on the real market, I would be making some subscriber fees to improve it constantly. To create such things requires an enormous amount of time and knowledge.

No one should expect to get a perfectly working AI bot beating the market for free. That's a dream.

from rl-bitcoin-trading-bot.

HoaxParagon avatar HoaxParagon commented on July 29, 2024

is abandon project ,no binance implementation is posible

The point was to provide a tutorial and he did that. I'm not sure why you were expecting a fully useable implementation. This is open source, make the interface yourself in a fork.

from rl-bitcoin-trading-bot.

kitmir avatar kitmir commented on July 29, 2024

When I started this thread, I had only in mind to see how this bot would act in a real world. At the end of the day it is always very nice to see if you get results.
this is definitely not a get rich quick scheme/code.
But thanks to this code I got to learn so much about RL and ideas/methods behind.
I am still exploring the code and learning. I don't know how many times I destroyed the code and started over :D (I know I am not the best person to keep track of the work)

But thanks to the author of this code and I wish your good work continues to educate others about machine learning and principles.

My advice to others is to google other platforms that has AI driven bots that you can buy the service for a small fee.
And this code is a tutorial to understand what is behind those bots.

from rl-bitcoin-trading-bot.

kitmir avatar kitmir commented on July 29, 2024

closing this thread since I believe that binance or other exchange implementations will be subject to individual work with its own risks.

from rl-bitcoin-trading-bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.