Comments (4)
Another option is to save all image files during a test to a folder (default to a temporary folder). Then you could upload this to an artifact in CI. This would lead to larger artifacts, but also has other advantages, for example being able to inspect for false negatives. I don't have a feeling one way or the other.
from pytest-pyvista.
To expand upon this: I think we should have two configurable directories. 1) the stored image cache, 2) the generated images for a single run.
- stored image cache. Can there be a universal way to set this? It should be related to the testing code, which could be hierarchical, so tricky to access here. If it is required to be explicitly set by the user, we should check that this is done, or raise an error.
- generated images. This could be in the shared appdirs by default.
It would also be great in the future to allow for an optional check that all the files in the cache dir have a corresponding file in generated dir, and vice versa. This would ensure that everything is working as expected during testing.
from pytest-pyvista.
I am doing this in pyvista/pyvista#3609 which would need to migrate here
from pytest-pyvista.
Good point. I'd rather this be to save all produced images, not just failing ones
from pytest-pyvista.
Related Issues (20)
- Consider removing appveyor.yml file HOT 4
- Add test-level option to choose image name for comparison
- Update development version to 0.2.dev0 HOT 1
- Documentation HOT 1
- Default cache_dir value could be better? HOT 5
- Not creating images for new tests HOT 1
- pyvista>=0.37 constraint can conflict with development installs HOT 3
- Add option to check if a cached image isn't compared to an image during all tests HOT 5
- Conflicting flags do not raise an error or warning. HOT 1
- reset_image_cache is not working HOT 1
- Implement getters/setters for VerifyImageCache attributes
- We really do not need a release branch for this package HOT 8
- Add pyvista tests into CI
- Teardown verify_image_cache after each test HOT 1
- Using a custom error class
- Reset cache only if error
- Release 0.1.9 HOT 7
- Test names case (in)sensitivity HOT 3
- CLI arguments are not aligned with Pytest arguments style HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytest-pyvista.