GithubHelp home page GithubHelp logo

RocksDB 版本更新? about nemo-rocksdb HOT 4 CLOSED

qihoo360 avatar qihoo360 commented on June 2, 2024
RocksDB 版本更新?

from nemo-rocksdb.

Comments (4)

KernelMaker avatar KernelMaker commented on June 2, 2024
  1. 你们用的是nemo-rocksdb的哪个分支?推荐使用public-release分支
  2. nemo-rocksdb与最新版rocksdb的兼容性应该不存在问题,DBNemo的Get是继承自rocksdb的DB,它里面是包含(string* value)定义的Get接口,我们测试使用最新rocksdb(9f2cc5)来编译,不存在不兼容的问题
  3. 新Get接口我们也会尽快支持

谢谢关注

from nemo-rocksdb.

KernelMaker avatar KernelMaker commented on June 2, 2024

nemo-rocksdb的master分支的确存在CopyFile不兼容的问题,我已经在代码中加了宏去区分,目前已经支持rocksdb的最新提交,你试试。

PS: nemo-rocksdb的master分支是给我们内部nemo使用的

from nemo-rocksdb.

jojo59516 avatar jojo59516 commented on June 2, 2024
  1. 我们 fork 了你们的 pika,更新了 rocksdb 至最新版本出现的问题,所以 nemo-rocksdb 默认是 master 分支
  2. rockdb v5.0.1(nemo-rocksdb 中使用的版本)中的声明是
    virtual Status StackableDB::Get(const ReadOptions& options, ColumnFamilyHandle* column_family, const Slice& key, std::string* value) override;
    所以
    virtual Status DBNemoImpl::Get(const ReadOptions& options, ColumnFamilyHandle* column_family, const Slice& key, std::string* value) override;
    重写了 StackableDB::Get(),而 rocksdb 更新至最新版之后 StackableDB 类中的声明变成了
    virtual Status StackableDB::Get(const ReadOptions& options, ColumnFamilyHandle* column_family, const Slice& key, PinnableSlice value*) override;
    导致现在 DBNemoImpl::Get() 重写了 DB::Get():
    virtual Status DB::Get(const ReadOptions& options, ColumnFamilyHandle* column_family, const Slice& key, std::string* value) = 0;
    所以我担心的是这样不会有问题么?

from nemo-rocksdb.

KernelMaker avatar KernelMaker commented on June 2, 2024

已经搞定了,你试试吧

from nemo-rocksdb.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.