GithubHelp home page GithubHelp logo

Comments (3)

iQuerz avatar iQuerz commented on June 12, 2024

@precondition this is the issue I've mentioned on the discord server. Thank you for looking into it :)

from qmk_firmware.

precondition avatar precondition commented on June 12, 2024

As far as I know, the code of the key overrides feature is not called when the modifier is released so I suspect that patching this issue will require turning on a bitset flag in quantum/process_keycode/process_key_override.c and checking for the activation of that flag in the core key processing code (e.g. in pseudo-code if (key.is_mod() && !key.pressed && MOD_BIT(key) & neutralized_mods) { tap_code(DUMMY_MOD_CODE_NEUTRALIZER); } unregister_code(key);)

Ideally, we would find a solution that only requires changes to the process_key_override.c file but I don't know if that's possible.

Another option would be to avoid re-enabling the modifier in the first place, which has the benefit of being easy to implement within process_key_override.c. However, this approach would break the following use case illustrated below:

Physical key Physical key status Keyboard report to the host
Left Alt down Left Alt
9 down Left Alt+DUMMY_KC → Home
9 up Left Alt
K down Left Alt+K
K up Left Alt
Left Alt up <empty>

In the hypothetical case where an Emacs user would want to move the cursor to start of the line with Alt+9 converted to Home firmware-side and then cut the entire sentence after the cursor with the Alt+K Emacs shortcut.

from qmk_firmware.

sigprof avatar sigprof commented on June 12, 2024

One option here is to emit the neutralizer in clear_active_override() if we are reregistering an affected modifier which was suppressed.

from qmk_firmware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.