GithubHelp home page GithubHelp logo

Merge fork-kde-master about qmlweb HOT 13 CLOSED

qmlweb avatar qmlweb commented on May 8, 2024
Merge fork-kde-master

from qmlweb.

Comments (13)

Plaristote avatar Plaristote commented on May 8, 2024

I took care of b73fd64 in pull request #24.

from qmlweb.

Plaristote avatar Plaristote commented on May 8, 2024

11164f0 is irrelevant now, since all that code was already re-aligned in qt.js.
3fab595 should probably be done another way, since QML elements aren't described the way they used to be.
8c6ec04 though it is slightly different, this task is already implemented in master.

Otherwise, I made a new pull request #29 which takes care of 02822c9, 3da78c7, 785965c, 1c12ea4, d35f213, c3f1f39, 12b725e, 4c9e432, 48db468 and a24ef6c.
Basically everything from 02822c9 to 48db468, plus the last .gitignore commit (a24ef6c). The next commits might require more work.

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

@Plaristote Great work! I updated the list above.

from qmlweb.

henrikrudstrom avatar henrikrudstrom commented on May 8, 2024

merged 9d4c4cf in #55

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

@henrikrudstrom Could you do that in a separate PR, please, and keep the original author?

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

Only 4 commits left here!

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

I will create a PR today to review the remaining commits here.

Update: apparently, I didn't.

from qmlweb.

Plaristote avatar Plaristote commented on May 8, 2024

I created PR #152 in order to merge 08a4558.

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

I opened #160 for 6022424 and #161 for 2865c68.

I guess those three PRs cover everything that is left here =).

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

One commit left! πŸ˜„

from qmlweb.

ChALkeR avatar ChALkeR commented on May 8, 2024

Yay, we got everything from kde master merged now.

from qmlweb.

Plaristote avatar Plaristote commented on May 8, 2024

Sorry :( ! Something went wrong when I merged #160... unfortunately, I noticed it after rebasing, and the PR was considered merged... I re-opened it as #176. We first have to fix some tests before landing it on master.

from qmlweb.

Plaristote avatar Plaristote commented on May 8, 2024

Alright, I was able to re-close thanks to that comment: #160 (comment) !

from qmlweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.