GithubHelp home page GithubHelp logo

Merge and commit landing process about qmlweb HOT 5 CLOSED

qmlweb avatar qmlweb commented on May 7, 2024
Merge and commit landing process

from qmlweb.

Comments (5)

ChALkeR avatar ChALkeR commented on May 7, 2024 1

@qmlweb/collaborators, I abolished the previous pr review process, so feel free to fix/commit/accept PRs on your own judgment. Waiting for reviews on complex and/or controversial things would still be good, but again — on your own judgment ;-). Given what I observed now, it would be easier for us to fix things later than to being idle and doing nothing here.

from qmlweb.

ChALkeR avatar ChALkeR commented on May 7, 2024

GitHub is not very good at this, afaik the «rebase» button is one of the most wanted features here.

from qmlweb.

henrikrudstrom avatar henrikrudstrom commented on May 7, 2024

found this: https://github.com/git-land/git-land, havent tested it yet.
and regarding 3:

If merging a PR, append [close #] to the last commit message so that Github will close the pull request when the merged commits are pushed.

from qmlweb.

ChALkeR avatar ChALkeR commented on May 7, 2024

A status update: GitHub added «squash and merge» option, so just using that for indivudual commits is fine, as long as you add the PR-URL and Reviewed-By information at the merge time (which could be added thought GitHub web ui).

I used that for merging #250, for example.

from qmlweb.

ChALkeR avatar ChALkeR commented on May 7, 2024

I guess I will just close this, enforcing the hard rules here just adds churn, «Rebase and merge» is now good enough. Will think about it more if there would be any issues with that.

from qmlweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.