GithubHelp home page GithubHelp logo

Comments (8)

janedbal avatar janedbal commented on July 18, 2024 2

I understand. I just think that Deptrac was very nicely customizable and extendable thanks to its event-driven design and the fact you have access to its DIC. That allowed us some neat customizations we needed. And now it got a bit worse :)

from deptrac.

janedbal avatar janedbal commented on July 18, 2024 2

Yeah, I know the risk and I'm willing to take it. Obviously I'm doing non-standard thing, I just wanna let you know that there are deptrac users that utilize its internal stuff.

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on July 18, 2024 1

By the way, with the new release model, I can release new version quicker! And I will try do release Deptrac more often!

My next goal is to figure out how we deploy the documentation 😅.

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on July 18, 2024 1

I’ve merged ‘Deptrac_Internal’ as the namespace prefix for Deptrac a dependencies.

See https://github.com/qossmic/deptrac-src/pull/48/files.
There is not a release wirh the static prefix, so there is still the possibility to change it.

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on July 18, 2024

I don’t think that the internal dependencies have ever been a public api. Properly a better solution would be to have a official extension point which is provided by Deptrac itself.

another option could be to prefix the dependencies with a static prefix. And people could still use those.

from deptrac.

gennadigennadigennadi avatar gennadigennadigennadi commented on July 18, 2024

With using the Symfony event from Deptrac your project adds a dependency. And if Deptracs decides to drop the Symfony stuff your code will break.

long story short: Deptrac should define extension points and document them. Maybe that’s already the case @patrickkusebauch ?

from deptrac.

patrickkusebauch avatar patrickkusebauch commented on July 18, 2024

I think a nice middle ground would be to have a static prefix for the Symfony Event Dispatcher, something like Deptrac\Symfony\Component\EventDispatcher\EventSubscriberInterface. That way the users can depend on a consistent name to extend that would not break between releases.

@janedbal do you think that would be good enough for your use case?

from deptrac.

janedbal avatar janedbal commented on July 18, 2024

If you insist on prefixing, then static one is definitelly better. Thank you

from deptrac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.