huge BUG with data lose! about qtodotxt2

[fuchsmich]

I'm having a look. Am 13.06.2017 um 17:45 schrieb oroulet:

…

@fuchsmich <https://github.com/fuchsmich> in current master if I add a new task, then it looks like the text of the new task replaces the text of the next task! as far as I understand there is something in the new tableview index but I could not find out where — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACw_MWoYX8naB6gNvGay2e1z9QMPHDpHks5sDq6JgaJpZM4N4sDV>.

[fuchsmich]

somehow the text of the correct task *and* the first task is set. I have no idea how this can happen... Am 13.06.2017 um 17:45 schrieb oroulet:

…

@fuchsmich <https://github.com/fuchsmich> in current master if I add a new task, then it looks like the text of the new task replaces the text of the next task! as far as I understand there is something in the new tableview index but I could not find out where — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACw_MWoYX8naB6gNvGay2e1z9QMPHDpHks5sDq6JgaJpZM4N4sDV>.

[fuchsmich]

I guess I found it.

…

On Dienstag, 13. Juni 2017 17:45:13 CEST oroulet wrote: @fuchsmich in current master if I add a new task, then it looks like the text of the new task replaces the text of the next task! as far as I understand there is something in the new tableview index but I could not find out where

[oroulet]

Ok. Where?

[fuchsmich]

Its in the taskline. inputAccepted() gets called multiple times. I'm working on a fix.

[oroulet]

I might be naive, but can you avoid tracking indexes? Can't you keep track of Task object?

[fuchsmich]

yes, this made it a lot easier.

[oroulet]

So now you have a solution that should work?

[fuchsmich]

As far as I see, yes.
There are still some error messages from qml, when creating a new task and then selecting a filter without quitting editing before.

[fuchsmich]

There are still issues, but data loss should not happen.
The problem is, that if you don't quit editing and then trigger a new action, the editing is quit by activeFocusChanged
https://github.com/QTodoTxt/QTodoTxt2/blob/qml/qtodotxt2/qml/TaskLine.qml#L54
which is too late, because the new tasklist seems to be populated already before the focus loss.

I have to investigate some more, but maybe we need a signal, which is emitted when an action gets triggered, which is about to change the content of the maincontroller.tasklist (setting filters, deleting/adding tasks etc.). Then we can quit editing upon this signal.

These problems also cause issue #35

[oroulet]

maybe we could just disable all actions while editing? it is a bit crazy to change filtering while editing ....

[fuchsmich]

That's one aproach I'm testing.

[oroulet]

You should remove HTML and text variable in that code. Just get them from task

[fuchsmich]

in the taskline? why?

[oroulet]

Do they help? Having them only increases the chance to make an error by forgetting to update them. And they generate an error sometimes