GithubHelp home page GithubHelp logo

Comments (7)

dabacon avatar dabacon commented on August 28, 2024

We no longer include the generated code because the engine code can use straight python dictionaries. However we should probably include bazel rules here anyway.

from cirq.

vtomole avatar vtomole commented on August 28, 2024

Would like to help with this if i knew what it meant. I'm willing to learn Bazel but there are no tutorials for Python: https://docs.bazel.build/versions/master/getting-started.html

from cirq.

vtomole avatar vtomole commented on August 28, 2024

Looks like Bazel rules are language agnostic. This is what I have in a BUILD file in cirq/api/google/v1

proto_library(
    name = "operations_proto",
    srcs = ["operations.proto"],
)

proto_library(
    name = "params_proto",
    srcs = ["params.proto"],
)

proto_library(
    name = "program_proto",
    srcs = ["program.proto"],
    deps = [
    "operations_proto",
    "params_proto",
    ],
)

from cirq.

dabacon avatar dabacon commented on August 28, 2024

@vtomole have you check to see if this compiles in Bazel? If so I think we should add these (without making bazel a requirement of Cirq, but I think this will be useful...at least it will be inside of Google!)

from cirq.

vtomole avatar vtomole commented on August 28, 2024

Bazel can compile it. Should I also send the WORKSPACE file? It's in Cirq/ and it contains

# This statement defines the @com_google_protobuf repo.
http_archive(
    name = "com_google_protobuf",
    sha256 = "cef7f1b5a7c5fba672bec2a319246e8feba471f04dcebfe362d55930ee7c1c30",
    strip_prefix = "protobuf-3.5.0",
    urls = ["https://github.com/google/protobuf/archive/v3.5.0.zip"],
)

Cirq$ bazel build //cirq/api/google/v1:program_proto
and friends can't succeed without it.

from cirq.

Strilanc avatar Strilanc commented on August 28, 2024

I had to kill the bazel step on travis because the jdk download started 404ing

from cirq.

dabacon avatar dabacon commented on August 28, 2024

we have valid BUILD files, but aren't using or requiring bazel. I think we should close.

from cirq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.