MultiModule Build: Resources Do Not Reload about quarkus-primefaces

[melloware]

@gesker confirmed removing this setting fixes your issue.

	<context-param>
		<param-name>jakarta.faces.FACELETS_REFRESH_PERIOD</param-name>
		<param-value>-1</param-value>
	</context-param>

You can do this if you want to set it for Production Mode only.

	<context-param>
		<param-name>jakarta.faces.FACELETS_REFRESH_PERIOD</param-name>
		<param-value>#{facesContext.application.projectStage eq 'Development' ? 2 : -1}</param-value>
	</context-param>

[melloware]

interesting. I was pretty sure all loading of resources was handled by Quarkus for any resources found under /META-INF/resources.

[melloware]

Also are you running mvn quarkus:dev from the root project or from the www project?

[gesker]

Always from root.

Right now I'm looking for a an old branch in my current project that was on Quarkus 2.x.

I don't think this was an issue on 2.x but I wouldn't bet the farm on it.

[melloware]

When I changed the html file I see this..

2023-06-13 16:45:24,879 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-6) Files changed but restart not needed - notified extensions in: 0.004s

But not when I touch your XHTML file. So in RuntimeUpdatesProcessor it doesn't think this file is changed or needs to be watched but I am not sure why.

Code: https://github.com/quarkusio/quarkus/blob/5c2df5112331ef170c0b0ad83c84c6f853c2d5d6/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java#L565

[gesker]

Before you deep dive... I'm not 100% sure the web.xml is correct. I did comment out all the CACHE configuration items

• trying to get back to default config - but I had been wondering traffic/filter was in the way or controlling the session in a way that I didn't understand - somehow determined the xhtml files didn't need to be reread -- and I simply hosed the configuration.

It was only after I was sure this wasn't happening in a known good project (quarkus-faces) that I figured I'd better file an issue.

I think my web.xml might be close but I've created complex problems from simple config mistakes before. Hopefully, my stare and compare was good enough to rule the the web.xml out a contributor.

[melloware]

Actually I am seeing this message now but still not updating the XHTML page.

2023-06-13 17:26:38,354 INFO [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-1) Files changed but restart not needed - notified extensions in: 0.004s

[tandraschko]

in general not a primefaces thing, more related to myfaces-core <> quarkus

myfaces should reload all xhtml files in ProjectStage.Dev from classpath
so i think either quarkus does not replace/reload the classloader stuff or MyFaces is not in Development stage or cache configured somehsow

[melloware]

@tandraschko what is weird is it reloads fine if the the projcet is a standalone project. But not if it is a submodule. You can see it with the MyFaces Quarkus Showcase project. If you run mvn quarkus:dev you will see it won't get hot updates of XHTML pages but Quarkus Faces does as its not a submodule project. It is very strange!

[tandraschko]

jakarta.faces.FACELETS_REFRESH_PERIOD — When a page is requested, what interval in seconds should the compiler check for changes. If you don’t want the compiler to check for changes once the page is compiled, then use a value of -1. Setting a low refresh period helps during development to be able to edit pages in a running application.The runtime must also consider the facelets.REFRESH_PERIOD param name as an alias to this param name for backwards compatibility with existing facelets tag libraries.

[tandraschko]

thats the problem

this setting should actually be not active in ProjectStage=Dev IMO

@melloware would you like to check if Mojarra ignores this flag in dev stage?
Otherwise, we should fix it in MyFaces anyway

[melloware]

Yep let me look!

[melloware]

This is what Mojarra does it forces -1 in production mode but in Dev mode if its set in web.xml it uses it but if NOT found it defaults to 2.

 // refresh period
        boolean isProduction = applicationImpl.getProjectStage() == Production;
        String refreshPeriod;
        if (webConfig.isSet(FaceletsDefaultRefreshPeriod)) {
            refreshPeriod = webConfig.getOptionValue(FaceletsDefaultRefreshPeriod);
        } else if (isProduction) {
            refreshPeriod = "-1";
        } else {
            refreshPeriod = FaceletsDefaultRefreshPeriod.getDefaultValue();
        }

[tandraschko]

IMO we should fix it in MyFaces

[melloware]

ok let me look at MyFaces

[tandraschko]

there is just no need to cache in dev mode IMO
but lets create a myfaces issue and a small vote

[melloware]

ok i will create an issue

[tandraschko]

also i dont know if EL is supported in this param
at least we have to support it or just ignore it in dev mode

[melloware]

https://issues.apache.org/jira/browse/MYFACES-4608