GithubHelp home page GithubHelp logo

Comments (11)

Robinlovelace avatar Robinlovelace commented on September 15, 2024 1

Tested and to my surprise it worked 1st time: geocompx/geocompy@6545593

Do you have any other tips on this @cderv ? Many thanks!

from quarto-actions.

cderv avatar cderv commented on September 15, 2024 1

is it easy to convert the book format to latex books like with bookdown (or indeed use bookdown)?

You should be able to set multiple output format for the book, including HTML and PDF.
https://quarto.org/docs/books/#getting-started

So building a book in both format should work. Like in bookdown but with some new features.

from quarto-actions.

cderv avatar cderv commented on September 15, 2024

Yes currently the gh CLI is a requirement as we need it to download the latest release for Github release page.

When creating this action, I assumed it would be used in Github Actions runners which all have the gh CLI. Wrong assumptiom.

Using it makes it really easy to get the latest release from the release page.

Is getting the gh CLI not possible in your case ?

I can find a workaround but it is less easy - gh CLI makes it really convenient. So if it could work for you that is easier.

I can add a check and a useful error at least.

What would be the desired behavior for you ?

  • Downloading the gh CLI directly in the action ?
  • Or not using it at all ?

thanks !

from quarto-actions.

Robinlovelace avatar Robinlovelace commented on September 15, 2024

All good questions.

Is getting the gh CLI not possible in your case ?

Yes that's possible and what I did. See here: https://github.com/geocompr/pytest/blob/main/.github/workflows/main.yaml#L17-L20

Is there a way to check if the gh tool is installed and install it with that if not? Also see the rest of that .yml file, as you'll see after going to the effort of installing the gh tool we just proceed to manually install quarto with a fixed version!

It's well worth making this action more robust IMO, lots of people will benefit who don't necessarily use vanilla GitHub images for their workflows.

from quarto-actions.

cderv avatar cderv commented on September 15, 2024

Is there a way to check if the gh tool is installed and install it with that if not?

You mean inside quarto-install action ? I guess we can do that yes. I wasn't sure if it was a good idea to install a tool that the user does not ask for. But I can also uninstall it maybe at the end, like cleaning.
Maybe that is not easier than not using the gh CLI tool for download.

we just proceed to manually install quarto with a fixed version!

This is now possible. It has been asked in #6 and just added in #7. You should now be able to do

    steps:
      - uses: quarto-dev/quarto-actions/install-quarto@main
        with:
          version: 0.3.63

from quarto-actions.

Robinlovelace avatar Robinlovelace commented on September 15, 2024

This is now possible. It has been asked in #6 and just added in #7. You should now be able to do

Great! And that does not require gh?

from quarto-actions.

cderv avatar cderv commented on September 15, 2024

Great! And that does not require gh?

It still does. But I can make it not use it in this case. Working on it ! 😅

from quarto-actions.

cderv avatar cderv commented on September 15, 2024

Great! And that does not require gh?

It does not require gh now when a version is specified.

I'll probably try to remove the gh requirement or install it in the action but this is simpler to do this for now. (would require a broader rewrite otherwise)

Does this work for you ?

from quarto-actions.

Robinlovelace avatar Robinlovelace commented on September 15, 2024

Not tested, but will aim to do so. Many thanks for the fix!

from quarto-actions.

cderv avatar cderv commented on September 15, 2024

So it works ? cool !

other tips on your workflow ? what other tips to you need ? I am not sure to follow, sorry. 😅

from quarto-actions.

Robinlovelace avatar Robinlovelace commented on September 15, 2024

Well any tips on using Quarto for newcomers to this rapidly evolving project, especially in relation to books. Specific (and I know off topic!) question: is it easy to convert the book format to latex books like with bookdown (or indeed use bookdown)?

from quarto-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.