Hue adjustment not working about quelea

[berry120]

This may be an issue with a library we're using (unless I'm missing something obvious, which is entirely possible.) It may be that something's also changed in VLC recently that means we need a different way of doing this.

caprica/vlcj#611

Will update as that ticket is updated.

[DeeTigIT]

VLC 3.0.4 in combination with Q 2018.1 (and also the Q CI-release) has this hue issue.
But VLC 2.2.8 in combination with Q 2018.1 (and also the Q CI-release) doesn't seem to have this hue issue. Advice for the time being therefore: downgrade VLC to 2.2.8 when using Quelea 2018.1 or Quelea CI.

[berry120]

This should now be fixed in the CI release (fixed in VLCJ.) Issue was that VLC 3 changed their API for setting hue values.

[DeeTigIT]

Hello Michael et al. The latest Q CI + older VLC 2.2.8: - Hue slider has no effect anymore - This is ok if only the latest VLC version is supported - Users using VLC 2 have to upgrade to VLC 3 The latest Q CI + latest VLC 3.0.6: - Without hue (slider left) there is already a hue applied on the display, it seems. (hue_no.jpg) - With hue (slider moved somewhat to the right) there is a change visible, but again: the hue on the display differs from Preview/Go Live. (hue_yes.jpg) Could there be some unwanted offset in the CI in the initial hue setting? (“slider left should be : hue = 0”) Regards, Dirk Van: Michael Berry [mailto:[email protected]] Verzonden: dinsdag 22 januari 2019 08:35 Aan: quelea-projection/Quelea CC: DeeTigIT; Comment Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) This should now be fixed in the CI release (fixed in VLCJ.) Issue was that VLC 3 changed their API for setting hue values. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AmCUFNwDpze54DY391LIjYcLnUf_L1VTks5vFr8pgaJpZM4UlqU4>.

[berry120]

Doing this in two seconds so no time to test at the mo, but I'm pretty sure I know why this is - VLC 3 changed the hue to have a -180 degree offset. Have just pushed an attempted fix. (Hue adjustment not working in earlier versions of VLC is expected.)

…

On Sat, 26 Jan 2019 at 11:13, DeeTigIT ***@***.***> wrote: Hello Michael et al. The latest Q CI + older VLC 2.2.8: - Hue slider has no effect anymore - This is ok if only the latest VLC version is supported - Users using VLC 2 have to upgrade to VLC 3 The latest Q CI + latest VLC 3.0.6: - Without hue (slider left) there is already a hue applied on the display, it seems. (hue_no.jpg) - With hue (slider moved somewhat to the right) there is a change visible, but again: the hue on the display differs from Preview/Go Live. (hue_yes.jpg) Could there be some unwanted offset in the CI in the initial hue setting? (“slider left should be : hue = 0”) Regards, Dirk Van: Michael Berry ***@***.*** Verzonden: dinsdag 22 januari 2019 08:35 Aan: quelea-projection/Quelea CC: DeeTigIT; Comment Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) This should now be fixed in the CI release (fixed in VLCJ.) Issue was that VLC 3 changed their API for setting hue values. — You are receiving this because you commented. Reply to this email directly, view it on GitHub< #8 (comment)>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AmCUFNwDpze54DY391LIjYcLnUf_L1VTks5vFr8pgaJpZM4UlqU4>. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHPkjS8JxtSdwLs-vvCyAF38WCzDx9a_ks5vHDhAgaJpZM4UlqU4> .

-- Thanks, Michael

[DeeTigIT]

Hi Michael, The latest quick fix does more harm, I’m afraid. Now multimedia video’s are also displayed with hue. And theme video’s (without the hue rule shifted) are still shown with hue. It took me some time to test this. Not on my usual PC, but on a notebook. My usual PC has an older graphics card: no hardware-accelaterated decoding possible in VLC 3. In the VLC 3 options I had to explicitely disable this hardware-accelerated decoding. Whereas in VLC 2 this setting was: default. With the latest Quelea CI, video’s don’t display anymore. Could it be that VLC is called from within Q with hardware-accelerated decoding set to ‘default’ or ‘on’? Regards, Dirk Van: Michael Berry [mailto:[email protected]] Verzonden: zaterdag 26 januari 2019 16:59 Aan: quelea-projection/Quelea CC: DeeTigIT; Comment Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) Doing this in two seconds so no time to test at the mo, but I'm pretty sure I know why this is - VLC 3 changed the hue to have a -180 degree offset. Have just pushed an attempted fix. (Hue adjustment not working in earlier versions of VLC is expected.)

…

On Sat, 26 Jan 2019 at 11:13, DeeTigIT ***@***.***> wrote: Hello Michael et al. The latest Q CI + older VLC 2.2.8: - Hue slider has no effect anymore - This is ok if only the latest VLC version is supported - Users using VLC 2 have to upgrade to VLC 3 The latest Q CI + latest VLC 3.0.6: - Without hue (slider left) there is already a hue applied on the display, it seems. (hue_no.jpg) - With hue (slider moved somewhat to the right) there is a change visible, but again: the hue on the display differs from Preview/Go Live. (hue_yes.jpg) Could there be some unwanted offset in the CI in the initial hue setting? (“slider left should be : hue = 0”) Regards, Dirk Van: Michael Berry ***@***.*** Verzonden: dinsdag 22 januari 2019 08:35 Aan: quelea-projection/Quelea CC: DeeTigIT; Comment Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) This should now be fixed in the CI release (fixed in VLCJ.) Issue was that VLC 3 changed their API for setting hue values. — You are receiving this because you commented. Reply to this email directly, view it on GitHub< #8 (comment)>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AmCUFNwDpze54DY391LIjYcLnUf_L1VTks5vFr8pgaJpZM4UlqU4>. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHPkjS8JxtSdwLs-vvCyAF38WCzDx9a_ks5vHDhAgaJpZM4UlqU4> .

-- Thanks, Michael — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AmCUFFgdc7uTu8luzuQFzkAimmg8HgObks5vHHtFgaJpZM4UlqU4>.

[berry120]

Oops, that'll teach me to try to fix something in a rush then run off... Another attempt at a fix pushed. I've actually made an effort to test it this time!

The hardware acceleration is a different issue but one we've had reported as well - the long and short of it is that the change / issue is with VLC, not Quelea. VLC 3 activates hardware accelerated decoding by default, whereas the 2.x branches had to have it enabled explicitly. I'm not aware of anything we can do to change this setting from within Quelea unfortunately.

[DeeTigIT]

Hey Michael, You’re effort paid off, the hue behaves as expected: · No hue on schedule videos. · Schedule custom theme with a video: o default no hue (the ruler at it’s most left position) o if the ruler is set: the corresponding hue is shown on the display For a short duration theme video (for example earth and sun.mp4 : 9 sec) with hue set, the hue disappears if the second iteration/loop of the video starts while projecting a song. Is this a known issue with VLC 3? Regards, Dirk Van: Michael Berry [mailto:[email protected]] Verzonden: dinsdag 29 januari 2019 22:20 Aan: quelea-projection/Quelea CC: DeeTigIT; Comment Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) Oops, that'll teach me to try to fix something in a rush then run off... Another attempt at a fix pushed. I've actually made an effort to test it this time! The hardware acceleration is a different issue but one we've had reported as well - the long and short of it is that the change / issue is with VLC, not Quelea. VLC 3 activates hardware accelerated decoding by default, whereas the 2.x branches had to have it enabled explicitly. I'm not aware of anything we can do to change this setting from within Quelea unfortunately. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AmCUFOhAPvzHfK9v5o-1moRYq94KJm8Uks5vILsUgaJpZM4UlqU4>.

[berry120]

Thanks for confirming! Afraid I don't see that issue though - the hue seems to stay on for me for all subsequent repeats of the video. @ArvidNy - don't suppose you're able to reproduce that one?

[ArvidNy]

Sort of, but it's not working at all for me. I can set it and the preview looks alright, but the live window is using the default value right from the initial loop. Here's some debug info I got if that helps:

[00007faf2c2312c0] chain filter error: Too high level of recursion (3)
[00007faf2c165ca0] main filter error: Failed to create video converter
[00007faf2c2afe70] main filter error: Failed to create video converter
[00007faf18052190] main video output error: Failed to create video converter
[00007faf18052190] main video output error: Failed to compensate for the format changes, removing all filters
[00007faf0404f860] vdpau_avcodec generic error: Xlib is required for VDPAU

[berry120]

Afraid they're red herrings put out by libVLC, nothing to do with the hue. Could be something to do with it being set differently on Linux of course...

…

On Thu, 31 Jan 2019 at 22:13, ArvidNy ***@***.***> wrote: Sort of, but it's not working at all for me. I can set it and the preview looks alright, but the live window is using the default value right from the initial loop. Here's some debug info I got if that helps: [00007faf2c2312c0] chain filter error: Too high level of recursion (3) [00007faf2c165ca0] main filter error: Failed to create video converter [00007faf2c2afe70] main filter error: Failed to create video converter [00007faf18052190] main video output error: Failed to create video converter [00007faf18052190] main video output error: Failed to compensate for the format changes, removing all filters [00007faf0404f860] vdpau_avcodec generic error: Xlib is required for VDPAU — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHPkjULscOUCxJAhg9izUJVafj5suWkfks5vI2qbgaJpZM4UlqU4> .

-- Thanks, Michael

[ArvidNy]

Might be. @DeeTigIT, do you also use a Linux distro?

[DeeTigIT]

I’m using the crossplatform Q on Windows. But I can’t reproduce the hue reset on a looping short theme video, unfortunately.. .. Verzonden vanaf mijn Windows 10-apparaat

…

________________________________ Van: ArvidNy <[email protected]> Verzonden: Friday, February 1, 2019 11:56:36 AM Aan: quelea-projection/Quelea CC: DeeTigIT; Mention Onderwerp: Re: [quelea-projection/Quelea] Hue adjustment not working (#8) Might be. @DeeTigIT<https://github.com/DeeTigIT>, do you also use a Linux distro? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AmCUFHn92_5CYpbUpjcVrSnOVeDwBR0Aks5vJB1kgaJpZM4UlqU4>.

[ArvidNy]

@berry120, I just read the javadoc for setHue and it states:

Video adjustments must be enabled for this to have any effect.

Just checked and isAdjustVideo returns false before we try to set the hue. I also checked setAdjustVideo which in turn states that:

The video adjustment controls must be enabled after the video has started playing.

Could the problem here be that adjustVideo is never successfully set after the video starts playing?