Found a site where the add-on makes scrolling impossible

#13 · closed · 7 comments

View on GitHub ↗

qoheniac

It's this one: https://banking.ing-diba.de

Comments

quinton-ashley

@hensm hi again, I can't figure out what the compatibility issue is with this site. Would you mind taking a look?

hensm

Can't reproduce.

qoheniac

I used Firefox 60.0.2.

quinton-ashley

hmm I found that on macOS and Windows versions of Firefox that site wouldn't scroll with the extension enabled.

qoheniac

I used the Linux version and it also didn't scroll.

hensm

Not sure there's a good solution for this one. Sites expect `<html>` to be the scrolling element, and the way this extension works breaks some of those expectations. It doesn't matter for most sites, but this one does some weird stuff that conflicts. Possibly this: ````css body > * { overflow: initial !important; } ```` Though, I think that's highly likely to cause collateral damage. For that specific site: ````css .off-canvas-wrap { overflow: initial !important; } ````

quinton-ashley

I tried that first css rule out in Stylus and found that it doesn't cause problems on quite a few sites I frequent but it breaks some pages on Twitter. Probably not a good idea to add it to the extension. I'm thinking a good solution for you @qoheniac is to include the css rule @hensm wrote for that specific site by adding the css with Stylus.