GithubHelp home page GithubHelp logo

Comments (11)

gioboa avatar gioboa commented on June 12, 2024 2

Yep, it will be merged. Thanks for your help @JerryWu1234

from qwik.

hosseinitabar avatar hosseinitabar commented on June 12, 2024 1

@gioboa, I'm sorry I don't know how to do that.

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024 1

Will this bug from v1 be merged into v2 when I finish this bug ?

from qwik.

gioboa avatar gioboa commented on June 12, 2024

Thanks @hosseinitabar
Would you like to create a PR for that?

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024

let me try it

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024

because the eslint 9.0 was a breaking change version, and I have used this library @eslint/eslintrc which the official have offered for migrate to v9.0,but it's still unstable , so we can wait a moment

eslint/eslintrc#158

from qwik.

wmertens avatar wmertens commented on June 12, 2024

I think we should use the ts one that helps with the types https://typescript-eslint.io/getting-started/

from qwik.

wmertens avatar wmertens commented on June 12, 2024

BTW @JerryWu1234 you need to rename your file to .cjs or it won't work in type:module projects. And maybe you should make it ESM with .mjs, but then __dirname needs to be replaced with the equivalent import.meta statement

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024

I think we should use the ts one that helps with the types https://typescript-eslint.io/getting-started/

we just upgrade the Eslint's grade. and follow this doc don't you?,
So why we have to refer a new library?

BTW @JerryWu1234 you need to rename your file to .cjs or it won't work in type:module projects. And maybe you should make it ESM with .mjs, but then __dirname needs to be replaced with the equivalent import.meta statement

I tried both ways, it's still wrong.

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024

typescript-eslint/typescript-eslint#8211

still going on for ESLint v9 Support

from qwik.

PatrickJS avatar PatrickJS commented on June 12, 2024

yup it would be awesome to convert those two files into one

from qwik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.