GithubHelp home page GithubHelp logo

pe's People

Contributors

qwoprocks avatar

Watchers

 avatar

pe's Issues

Uninformative error message for addmodule

As per image below, although the module name is clearly alphanumeric, it is still not accepted by the system. Perhaps change it to "Only valid module codes will be accepted"

image.png

Display of zoom links slightly lacking

  1. I understand that the bottom part of the module display panel is for Quiz display, but when there are no quizzes, it leaves a very jarring blank space, as per the below screenshot:

image.png

  1. The zoom link cannot be fully seen when the display is too small/zoom link is too long, and also cannot be highlighted. The only place where it is stated that the zoom link can be copied by clicking on it is in the UG, and it seems that I have to double click to actually copy it (I tried by first clicking one zoom link then clicking another, only works for the second one when i double click). There is a lack of visual feedback in the application to indicate that the zoom link has been copied, and the result display remains as the previous command's result. I suggest changing the zoom link to a highlightable text field instead, and having a button or some other visual feedback when copying over the zoom link.

image.png

The pie chart changes color, but not sure why it does.

As per title. This might confuse the user, since there appears to be no trigger for the color change. Not sure if there's a reason for the color change. But the animation is pretty cool

Before:
image.png

After:
image.png

Even when a command has no actual effect, it still changes the color

Before running completetask 1 on the completed task 1:

image.png

After runnning:

image.png

View module does not update upon command

Before running the addzoom command:

image.png

After running addzoom 2 n/lecture-weds z/https://nus-sg.zoom.us/j/auya7164hg:

image.png

Then immediately running viewmodule 2

image.png

As you can see, the module details display only updates after you call viewmodule, and not on any change to the module itself, which makes it very confusing for the user.

I have tested it out with other commands, and since it doesn't update with even the 'undo' and 'redo' commands, I'll be upgrading this severity to high. It is super confusing when you keep typing undo and nothing on the screen changes, not even the result display for the command.

Contact list UML diagram inconsistencies

Should the boolean be a box by its own? "boolean" is a primitive and thus I think it would be better to put it in the "Contact" box as a field. Also, the package names should have their first letters capitalized, e.g. "Contact" and "Tag", as per other UML diagrams.

image.png

Inconsistency in UML diagram page 26/114 DG

As per title. The name of the ArchiveModuleCommand is "a" but "command" is returned instead. The "CommandResult" isn't given a name but "result" is returned from the ArchiveModuleCommand after the "execute" call. This is inconsistent with all DG diagrams that came before it.

image.png

Slight inconsistency with UML diagram in Model section of DG

I think the dashed arrow is supposed to come from outside the Model box, as per the other diagrams in the DG.
Also, if the ReadOnlyUserPrefs is an interface, it should have the <> tag, and if it is not, the arrow pointing at it should be solid, not dashed.
Lastly, aggregation is not encouraged as per textbook, it would be good if it's changed to composition.

image.png

Uninformative addmodule / addcmodule error

Refer to ss below. The module name only contains alphanumeric characters, yet it is rejected because of the small letter 's'. Changing it to uppercase causes the command to pass. The error message should be changed to reflect this constraint.

image.png

UI component section in the DG is not updated completely

The image is updated but the description doesn't seem to be. Refer to two ss below where 1st image shows several components under MainWindow, but the 2nd (description) doesn't seem to reflect this fact, for example statusBar instead of StatusBarFooter, and the lack of the HelpWindow component. Also, under the 2nd image, the "API:" part is empty.

First image:
image.png

Second image:
image.png

Header fails to render

As per title. See image below. There should be a space between # and the word after it. e.g. "...# Edit" and "...# Delete"

image.png

image.png

Resizing the window causes a disjointed display

As per title. It can be seen that the scrollbar cuts off halfway, and the calendar is located at a weird position, with the right border cut off as well.

image.png

I realise that the calendar is located there because the top panel is reserved for module displays and stuff, but it makes it very confusing to the user.

Issues with Design Consideration in DG

First Aspect is blank? I'm not too sure if this is intentional.

The word "Cons" isn't separated from the previous line. Makes it look like everything is under Pros if you don't read properly.

image.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.