I think recent changes have broken devel devtools on travis about callr

[gaborcsardi]

Oops. Sorry. Reverted and will investigate.

[gaborcsardi]

But then, how did an older devtools version fix this?

[jimhester]

Current devel devtools uses callr, older devtools does not!

[gaborcsardi]

I just just don't see it. The new version of callr will not require quoting external commands and arguments, but the only devtools-related code that uses callr with quoting is here: https://github.com/r-pkgs/pkgload/blob/master-clean-start/R/install-min.r#L15-L16
and it seems that this code was already removed from pkgload.

Am I missing sg?

[gaborcsardi]

Aha, I think I got it. Here:
https://github.com/r-pkgs/pkgbuild/blob/5ed87aa1c6f0482123d53a242df3dbc058e39f2c/R/compile-dll.r#L147-L148
and probably here as well:
https://github.com/r-pkgs/pkgbuild/blob/551a3c7e7f6f80dc8edc35039613c43f2a89e7fe/R/build.r#L71

Anyway, we need some (small) transitioning plan for these, because callr will not work with quoting. So at some point we just need to remove the quoting from pkgbuild, and I guess also add a remote to the newer callr version.

[jimhester]

Yeah I think pinning devtools / pkgbuild to callr before the quoting, then we can fix pkgbuild /devtools and update the remote.

[gaborcsardi]

@jimhester OK, here is the plan. Only pkgbuild is affected. devtools and pkgapi and pkgdown also use callr, but they are not affected.

• I submit a PR to pkgbuild, that pins callr
• @jimhester merges the PR
• I update callr to use processx.
• I submit a PR to pkgbuild that pins callr to the new version (?), and removes the shQuote().
• @jimhester merges the PR
• ... time passes ...
• I put the new callr on CRAN (also needs processx, etc. on CRAN)
• I submit a PR to pkgbuild to remove the pinning and the callr remote entirely
• @jimhester merges the PR

OK?

[jimhester]

👍 , it is up to you if we pin the new callr version or just let it track the head of callr, in some ways I prefer the latter so we uncover issues sooner, but it is your call.

[gaborcsardi]

@jimhester pinning PR submitted.

[gaborcsardi]

it is up to you if we pin the new callr version or just let it track the head of callr, in some ways I prefer the latter so we uncover issues sooner, but it is your call.

Can I pin to HEAD ? Just because if I just say r-pkgs/callr, then nothing indicates that the old version is bad....

[jimhester]

Both r-pkgs/callr@HEAD and r-pkgs/callr@master seem to work

[gaborcsardi]

Thanks, submitted another PR.

[gaborcsardi]

Thanks again. It seems that actually devtools needs a PR as well:
https://github.com/hadley/devtools/blob/2e3c4b692e3aecd7a4fd746e3000db1f4aa706bd/R/install.r#L158

[gaborcsardi]

@jimhester PR for devtools: r-lib/devtools#1493

[clocklear]

This appears to still be broken, in some capacity. We're getting extra quotes in our devtools -> callr interactions:

> devtools::install_git('http://<our on-prem git solution>/dsc/coreFunctions.git', force = T)
Downloading git repo http://<our on-prem git solution>/dsc/coreFunctions.git
Installing coreFunctions
Running command /Library/Frameworks/R.framework/Resources/bin/R 
Arguments:
CMD
INSTALL
/private/var/folders/f5/7fhn61rj61nfq4s29ww0sk5jrmxt2m/T/RtmpklYkmZ/fileb1b368156e15
--library='/Library/Frameworks/R.framework/Versions/3.3/Resources/library' --install-tests 
Error: ERROR: cannot cd to directory ‘'/Library/Frameworks/R.framework/Versions/3.3/Resources/library' --install-tests’
 
Installation failed: NULL : Command failed:
  
 Error: ERROR: cannot cd to directory ‘'/Library/Frameworks/R.framework/Versions/3.3/Resources/library' --install-tests’

Note that R CMD INSTALL is trying to cd to the ‘'/Library/Frameworks/R.framework/Versions/3.3/Resources/library' --install-tests’ directory, which is obviously a quoting problem.

[gaborcsardi]

Yes, I think the shQuote form here needs to be removed:
https://github.com/hadley/devtools/blob/90a866b594389bacb2e579c358fd71736410606a/R/install.r#L145

@jimhester can you remove it pls?

[clocklear]

I made that change in our local copy and it's still trying to include the entire opts array in the cd. It's hacky, but I had to also comment out the --install-tests. I'm not sure why it's interpreting the entire opts as a path.

[jimhester]

Should be fixed by r-lib/devtools@ab176e6

[gaborcsardi]

Oh yes, --install-tests should be separate argument....

…

On 12 Apr 2017 17:50, "Cory Locklear" ***@***.***> wrote: I made that change in our local copy and it's still trying to include the entire opts array in the cd. It's hacky, but I had to also comment out the --install-tests. I'm not sure why it's interpreting the entire opts as a path. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAoTQLHUaB6TP8Ng0_nQPTtokfB7Q46_ks5rvQDFgaJpZM4M0kC0> .

[gaborcsardi]

@jimhester great, thanks!

[clocklear]

Agreed, thanks to both of you for the quick turn-around!