Comments (4)
Hmm I guess the problem here relates to the usage of DestinationsNavigator
, correct?
This is an easy fix, all we need to do is add a method to the DestinationsNavigator
interface that receives a Uri and implement it calling the corresponding method in the NavController
.
In the meantime, you can simply take the NavController
as a parameter to the Composable and that will also allow you to navigate with Uri.
So to be honest I'm torn as to whether or not to implement this method in DestinationsNavigator
.
Because I'd like to keep this wrapper as thin as possible. I think for more "exotic" use cases where you really want to be navigating inside your app with deep links (this is the only use case to navigate with a Uri right?) maybe it is ok to depend directly on NavController
?
What do you think?
from compose-destinations.
from compose-destinations.
Yes, both are valid as arguments to Destinations.
The wrapper is useful if you want to test or preview these Composables, but you can always just call an overload version of the Composable that only receives lambdas and state.
But you're right that this deserves a mention somewhere. I'll think about it. Thanks for the feedback 👍
from compose-destinations.
Updated wiki to mention this, so I'm closing this issue. Let me know if there is actually something else you'd want to see mentioned or fixed.
https://github.com/raamcosta/compose-destinations/wiki/Navigation#navigating
from compose-destinations.
Related Issues (20)
- IDE plugin for visualizing the navigation graphs HOT 1
- Multi-module setup throws compilation error that start route does not exist. HOT 3
- Incompatible with androidx.navigation 2.8.0-alpha06 and newer HOT 1
- Theme doesn't carry over to other destinations HOT 1
- Navigate to another module with args HOT 3
- NavTypeSerializer HOT 3
- ModuleDestinations$Includes is defined multiple times in Multi-Module project HOT 4
- [ksp] java.lang.NullPointerException when using custom NavArgument type HOT 13
- No NavGraphs in V2 HOT 14
- Support for Shared Element Transition. HOT 2
- Tab navigation support. HOT 1
- Can not make dependenciesContainerBuilder example work HOT 2
- Serializer for class 'DirectionImpl' is not found in v2 HOT 10
- [2.1.0-beta03] Navgraphs.* cannot be imported in the generated NavGraphs HOT 3
- navargs.* cannot be imported in ArgsToSavedStateHandle.kt HOT 2
- HorizontalPager pageContent can't save state HOT 2
- NavGraphArhs are visible only in "start" destination HOT 6
- Removing from composition and re-adding when navigating HOT 3
- java.lang.IllegalStateException: Duplicate route found X_destination'. Routes must be unique!. In Muli-module project. HOT 2
- Missing classes detected while running R8 on AGP 8.4.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-destinations.