GithubHelp home page GithubHelp logo

Comments (3)

zmillman avatar zmillman commented on May 25, 2024

@flevour why should this be part of rack-attack instead of a separate HTTP code-tracking Rack middleware?

from rack-attack.

ktheory avatar ktheory commented on May 25, 2024

@flevour: Interesting. I'm hesitant to expand the track functionality to include responses. Adding tracks for requests was b/c it was such a close fit to how we're already blocking & throttling other requests.

For simplicity and focus, I'd like to keep parsing responses outside the scope of rack-attack. You could implementing response tracking as a separate middleware or gem (per @zmillman's suggesting).

from rack-attack.

flevour avatar flevour commented on May 25, 2024

In my case I'd want to throttle only successful requests to API over a given period.
Basically I'm re-using the whole rack-attack count-over-period logic but to throttle responses.
I see your point about simplicity/focus though, thanks for sharing your thoughts!

from rack-attack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.