GithubHelp home page GithubHelp logo

Comments (9)

racodond avatar racodond commented on September 27, 2024

Hi Armand,

It doesn't seem to be fully supported by all browsers without vendor prefix (Firefox for instance). Thus, I'd like to keep it as 'experimental' for now.

I already thought about it and it could be the right time to implement it. I can add a custom parameter to the rule that would allow some properties to no longer be considered as experimental. Would that answer your need?

Thank you

Regards,

David

from sonar-css-plugin.

ARMANDVDM avatar ARMANDVDM commented on September 27, 2024

Hi David,

Thanks for the response. A custom parameter will surely do the trick. If we're able to define our own exceptions without switching off an entire blanket rule then that would bring a whole lot of flexibility to our development cycles. For example, we had to switch off a whole lot of stuff the other day for the placeholder pseudo class as well since our client was very particular on the colour of the placeholder text in our app and quite frankly that makes me very nervous :)

Thanks for your feedback and looking forward to your reponse.

Best Regards
Armand

from sonar-css-plugin.

racodond avatar racodond commented on September 27, 2024

Hi Armand,

A custom parameter will surely do the trick. If we're able to define our own exceptions without switching off an entire blanket rule then that would bring a whole lot of flexibility to our development cycles.

OK. Issue created: #102

For example, we had to switch off a whole lot of stuff the other day for the placeholder pseudo class as well since our client was very particular on the colour of the placeholder text in our app and quite frankly that makes me very nervous :)

Can you tell me a bit more to see if we can do something about it?

Regards,

David

from sonar-css-plugin.

ARMANDVDM avatar ARMANDVDM commented on September 27, 2024

Hi David,

Thanks for this.

With regards to your question, we had to switch off the whole "scss:experimental-pseudo-usage" rule to change the colour of the placeholder text meaning that Sonar would now accept all of the other experimental pseudos like any-link, backdrop, blank, content etc. The only ones that we would possibly want to use out of that entire rule at a glance would be has and placeholder. I believe if we had the ability to switch off Sonar checking on certain experimental properties and pseudo classes as opposed to allowing all of it to slip through by switching off the entire rule then that will be very useful.

I hope this answers your question.

Thanks again & Best Regards
Armand

from sonar-css-plugin.

racodond avatar racodond commented on September 27, 2024

Hi Armand,

I extended #102 to target properties, pseudo elements, functions and @-rules.

Regards,

David

from sonar-css-plugin.

ARMANDVDM avatar ARMANDVDM commented on September 27, 2024

Hi David,

Thanks for this.

Best Regards
Armand

from sonar-css-plugin.

racodond avatar racodond commented on September 27, 2024

Here's a snapshot that adds a parameter to the experimental-property-usage rule: https://github.com/racodond/sonar-css-plugin/releases/tag/fix102. Tell me if it suits your needs. If so, I'll extend the rule to functions, at-rules, pseudo-elements.

from sonar-css-plugin.

ARMANDVDM avatar ARMANDVDM commented on September 27, 2024

Hi David,

We have implemented your change and it works fantastically well.
I think its safe to say that you may proceed to extend this rule to the functions, at-rules and pseudo-elements.

Many thanks!

Regards
Armand

from sonar-css-plugin.

racodond avatar racodond commented on September 27, 2024

Thanks for your feedback!
I just released a new version with this enhancement: https://github.com/racodond/sonar-css-plugin/releases/tag/4.16

from sonar-css-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.