GithubHelp home page GithubHelp logo

Comments (7)

zernonia avatar zernonia commented on May 20, 2024

Thanks for the provided fix @maelp ! I realize Textarea for default is not as complete as new-york style. And we prefer using useVModel to standardize the usage of v-model.

This should be simple fix 😁

from shadcn-vue.

maelp avatar maelp commented on May 20, 2024

ah nice ! the widgets are different in both versions? then we might perhaps review them to have equivalent features?

from shadcn-vue.

maelp avatar maelp commented on May 20, 2024

Also I'm using the Popover and tooltip and other hover items from the "standard" lib (not new-york") and there are small bugs like:

  • if it opens near an edge of the screen, it goes out of the screen (rather than staying at most at left=0 or right=0 to be completely in screen)
  • similarly, if it opens near the bottom, the popover / tooltip / dropdown / select still opens below the widget (and therefore goes out of the screen) rather than opening on top (like it does in the radix-vue demo site)

is that a bug with the standard implementation? is it fixed in new-yrok? or should we work on a fix?

from shadcn-vue.

ahmedmayara avatar ahmedmayara commented on May 20, 2024

There's a prop called avoidCollisions I guess that this prop is not set to true by default in both styles (new-york and default). It's a simple fix you can open an issue and fix it if you want to.

from shadcn-vue.

maelp avatar maelp commented on May 20, 2024

Done (BTW did we fix the textarea in standard?)

from shadcn-vue.

ahmedmayara avatar ahmedmayara commented on May 20, 2024

The <Combobox /> component is built using a composition of the <Popover /> and the <Command /> components. That's why it is not implemented as seperate component in the registry folder.

from shadcn-vue.

ahmedmayara avatar ahmedmayara commented on May 20, 2024

Yes, the <Textarea /> component is fixed. I already did that so that's why I closed this issue.

from shadcn-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.