Refactor code to improve testability about git-changelog

[rafinskipg]

I cannot agree more on that, Johnny.

All what you suggest would be a great adition to git changelog. Once we are done with the refactors we can move to the changelogrc stuff.

Feel free to pullrequest whatever you want :)

[estilles]

Already started working on the PR. Should submit within a day or two.

[estilles]

@rafinskipg, I do have a question. What is the purpose of tasks/hacky.js?

[rafinskipg]

It is unused, it was used prior to have the CLI option available. :)

[estilles]

Good. I was trying to figure out what it was, and it was driving me nuts! I will remove for cleanup purposes.

FYI ... I'm done refactoring. I working on the adding additional tests now.

[rafinskipg]

Ty! 💯

[rafinskipg]

Hi @JohnnyEstilles The PR is merged, i have added also some changes to the writeStream that were producing weird behaviours since the beggining. The stream was not closed and sometimes the files weren't written well.

   stream.end();
    stream.on('finish', function() {
      deferred.resolve();
    });

Thank you for the nice improvements, i'm going to release version 0.1.7

[estilles]

Would you mind reopening this issue? There are still some pending tasks. I would prefer to close it when I'm done.

[estilles]

Did you run the tests before you pushed?

[rafinskipg]

Ok, yes, i saw it, now they are fixed. 👍

[estilles]

Good job with the fix! :-) Almost done with this issue.

[estilles]

We need to work on our code climate score. 1.7! We can do better. :-)

[estilles]

Code climate up to 4.0, coverage at 96% ... Now we're cooking. Going to close this issue now.