Comments (4)
Duplicate/Related to #51111?
from rails.
Duplicate/Related to #51111?
Not really, that is about how data is read back from the database and the change that unbounded values now comes back as nil
where the before Rails 7.1 came back as Float::INFINITY
, which I think is a change to the better.
This is about what how the data is going into the database. When a boundless end is sent to PostgreSQL it is sent as nil
which in PostgreSQL will be stored as an excluded end, but if it is sent as infinity
it will be stored as inclusive, and be returned as such.
It is possible that this could be considered a PostgreSQL problem too, because range = ["2024-01-01 00:00",infinity]
could be the same as range = ["2024-01-01 00:00",]
, but the latter is saved as ["2024-01-01 00:00",)
.
From what I can tell, the value that goes into the database has to be modified from nil
, to string infinity
. But I could be wrong.
from rails.
It's inserting as "[2024-01-01 00:00:00,]"
, and it looks like Postgres will convert it to "[2024-01-01 00:00:00,)"
(exclusive).
Looks like we have to be explicit with the infinity
.
from rails.
All of these ranges in your test case:
# range = (@time..Float::INFINITY)
# range = (@time..DateTime::Infinity.new)
# range = (@time..Date::Infinity.new)
Will pass with this change:
I'm still investigating if this change is the right approach ... haven't even run the rails tests yet.
If we detect if the range is a date/time range, then we could have (@time..)
with infinity
... but then you get into "special case land" and I'm not sure that's a path to go down.
from rails.
Related Issues (20)
- PostgreSQL Apache AGE Rails (GraphDB driver questions / problems) HOT 6
- s
- Release 7.0.8.2 contains broken trix.css HOT 2
- Queries generated incorrectly in class methods HOT 2
- Order of operations for saving nested associations has changed in Rails v7.2 with automatically_invert_plural_associations enabled HOT 7
- rescue_from not working with subscribed method on ActionCable channel HOT 2
- Production rails server does not boot if skipping action cable in Rails 8.0.0.alpha HOT 2
- Generate Migration - Rename Table HOT 6
- Rails 7.1 Transactional tests, threaded code and schema caching can cause deadlocks HOT 1
- /Users/amol/.rvm/gems/ruby-2.5.1/gems/activerecord-5.0.2/lib/active_record/connection_adapters/mysql2_adapter.rb:68: [BUG] Segmentation fault at 0x94000f78d65f0300 ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin23] HOT 1
- Support enum in tableless model HOT 4
- `ActiveStorage::Attachment` - Unhandled case where `named_variants` can be `nil`
- `ActiveSupport::BroadcastLogger` with `ActiveSupport::TaggedLogging` throws `no implicit conversion of String into Integer (TypeError)` HOT 3
- Guides: Explain reset_column_information in Chapter "Migrations and Seed Data"
- One of `ApplicationTests::ConfigurationTest` fails with sqlite3 gem that bundles sqlite v3.46.0 HOT 3
- Add a datetime_local method on Time and DateTime classes - typical rails convenience HOT 1
- Deferred route drawing causes problems with some tests
- Incorrect documentation for authenticate_or_request_with_http_token HOT 1
- Regression in URL generation in Rails 7.1 HOT 13
- ActionCable tests fail when encrypted cookie is set with options
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails.