GithubHelp home page GithubHelp logo

Comments (4)

justinko avatar justinko commented on June 26, 2024

This fixes it but I don't think it's the direction we want to go in: justinko@2fc0ded

I think there's some confusion about responsibility between database_tasks.rb and databases.rake. I'm looking into it.

from rails.

zzak avatar zzak commented on June 26, 2024

@justinko I think a problem with that approach is that those tasks already call establish_connection, e.g.:

establish_connection(public_schema_config)

from rails.

justinko avatar justinko commented on June 26, 2024

Which is essentially idempotent/no-op as connection on the next line is the same connection from with_temporary_connection (in my branch). At least it is with the mysql tasks, as that's all I've tested so far.

Not saying this is the correct approach but we do need to find a clean way to restore to the original db config.

from rails.

justinko avatar justinko commented on June 26, 2024

@zzak ready for review #51862

from rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.