Comments (4)
Option 1 is better
from revoke.net.
Sounds good, i'll get started on Option 1 and make a pull request.
I will reach out if I have any questions.
Safer is always better 😄 thanks for the quick input 🚀
from revoke.net.
Hello!
I started to implement this here: https://github.com/jeffward01/Revoke.NET/tree/async-suffix
I noticed that the other projects rely on Revoke.Net version 2.0.1
from Nuget.
We could do something like:
Publish new version of Revoke.Net with the async methods to nuget: version 2.0.2
as an example,
Then after its 'live', I can work on upgrading the other projects.
What do you think?
If this is ok, I have made my PR, please publish the version to nuget, so I can start on converting the other projects.
You'll need to:
- Accept the PR
- Update the version number
- Create a new release
- Publish to nuget
Is this ok?
Question:
- Do you think they'll be any issues with the other projects? I think no, because the other projects will target
2.0.1
, not2.0.2
.
Thanks
from revoke.net.
I didn't realize I had Collaborator rights, thank you!! Very excited to help on this library. You are awesome.
I looked to see if I could perform the steps
- Accept the PR
- Update the version number
- Create a new release
- Publish to nuget
But it appears as if you don't have a GitHub Action / Trigger set up, so I am assuming you manually deploy the package to Nuget?
At a time in the near future I can implement a Github Action trigger, I will just need you to popular a repository variable (I wont have access to it) with your Nuget API token.
Here is a tutorial on how you can set up the API key. There are many other tutorials that you can review as well. Let me know if you need any help with this. Thanks
from revoke.net.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revoke.net.