Comments (8)
@eli-schwartz I resolved this issue in my version of rTorrent. The fix was very simplistic. It will build with LTO now on Gentoo Linux.
stickz/rtorrent@6332d39
Just need to run git clone if you're interested and follow the build instructions: git clone https://github.com/stickz/rtorrent
https://github.com/stickz/rtorrent
from rtorrent.
Correct me if I'm misunderstanding, but utils/directory.h:46:8:
and input/./../utils/directory.h:46:8
are the exact same file, so it sounds like whatever build system gentoo is using is generating duplicate definitions for itself in the libsub_*.a files. Using the documented build process with -Werror=odr
compiles perfectly fine for me.
I doubt rTorrent will ever officially support gentoo's build system, but even if I wanted to help unofficially, there's not any information on how to reproduce.
from rtorrent.
Correct me if I'm misunderstanding, but
utils/directory.h:46:8:
andinput/./../utils/directory.h:46:8
are the exact same file, so it sounds like whatever build system gentoo is using is generating duplicate definitions for itself in the libsub_*.a files. Using the documented build process with-Werror=odr
compiles perfectly fine for me.I doubt rTorrent will ever officially support gentoo's build system, but even if I wanted to help unofficially, there's not any information on how to reproduce.
The best way to reproduce would be to open the attachment titled "full logs" and check for information on how to reproduce.
In short, Gentoo is not using an alternative build system, there's nothing specific to Gentoo here.
It's just running configure and make.
I would be happy to provide any additional details needed but if we can't agree on whether or not the official configure and make scripts were used then I'm not sure how much anything I say matters.
from rtorrent.
So there's no set of emerge commands I could run to quickly reproduce on a gentoo docker image or anything? I spent some time looking at the log, and tried docker run gentoo/stage3 "emerge --sync && emerge '=net-p2p/rtorrent-0.9.8-r2::gentoo'"
, but didn't get any error. Trying to adapt the configure command to my system would be possible but also seems pretty tedious (not to mention trying to match toolset versions), so if there's an easier way it would be greatly appreciated.
from rtorrent.
In the Gentoo container, if you add these flags to /etc/portage/make.conf
as part of CFLAGS / CXXFLAGS / LDFLAGS, it should demonstrate the issue:
-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
Note: -flto is needed to produce LTO code generation, and the -Werror=* flags cause the link-time "lto-wrapper" based codegen to fatally error when safety constraints are violated.
In principle it should reproduce with a plain configure and make, when using those flags. I hastily tried that with rtorrent from a git clone, but it didn't appear to compile due to libtorrent version differences and I didn't have time right then to chase that down.
"Probably", using those flags on your own system with your own toolset versions and whatever configure command you usually use, would be enough too.
from rtorrent.
I gave it enough of an effort to ensure that it's really LTO shenanigans at play, rather than a true ODR violation. It doesn't seem insurmountable, so maybe I'll take another shot later, but all the solutions I found didn't seem to be worth the increase in complexity.
from rtorrent.
Cool :) is there a PR including that commit?
from rtorrent.
Cool :) is there a PR including that commit?
No, I had to rebuild the repo to get the commit history. There's just a commit.
from rtorrent.
Related Issues (20)
- Optimization opportunity for hash checks of partially downloaded files
- Better way to organize torrents in the main view, e.g. by label or watch/download directory HOT 5
- freezes 20+ torrents, tracker related HOT 2
- Error in VPN-with-Traffic-Splitting wiki HOT 1
- Periodic peer disconnect and idling data transfer intervals HOT 3
- error with config after update HOT 2
- Crash Error: Success Signal code '2': Non-existent physical address. HOT 1
- what process should I do on Debian 11? HOT 1
- [Bug Report] [Failure reason \"This client is not allowed...] HOT 3
- Zero peer/seeds after restart HOT 1
- Ratio Groups - seed time - discrepancy between rTor and tracker
- A new release? HOT 3
- Actual up to date build instrunctions, please?? HOT 2
- Default rtorrent settings HOT 2
- Buffer overflow bug on Ubuntu 24.04 HOT 3
- Couldn't set static incoming listen port properly HOT 6
- Option to release inactive file descriptors automatically after some time
- libxmlrpc_util.so.3: cannot open shared object file HOT 2
- Segfault when rTorrent runs on pretty busy drive
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtorrent.