GithubHelp home page GithubHelp logo

Comments (3)

ralphm avatar ralphm commented on July 26, 2024

Hi @javelin,

Thanks for reporting this.

I realize that you haven't made your change in f1fa71d into a pull request (yet?), but the implementation doesn't seem correct. MUC servers will only send roles and affiliations when they change. With your commit, the user's role and affiliation attributes would be set to None in other presence updates, which doesn't seem desirable.

Also, when you do make this into a pull request, could you maybe also add some unit tests?

Cheers!

from wokkel.

ralphm avatar ralphm commented on July 26, 2024

Bump

from wokkel.

ralphm avatar ralphm commented on July 26, 2024

This was fixed as part of #12.

from wokkel.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.