GithubHelp home page GithubHelp logo

Comments (4)

ramnes avatar ramnes commented on May 20, 2024 1

The most common method in that kind of scenario is to mock the library completely. Another solution is to use cassettes, just as we're doing in notion-sdk-py (instead of mocking httpx). It requires a test account or a template page for when you're writing new tests or updating the API calls made in previous tests, but the good point is that the rest of the time, i.e. when anyone just changes a few things, all the API calls are perfectly mocked without effort.

from notion-sdk-py.

ramnes avatar ramnes commented on May 20, 2024 1

What do you mean by mock the library completely ?

Monkey patching the library during the tests so that it returns what you assume it would always return in your scenarios, so that you can run the test without an API key.

The basic way to do this is with unittest.mock. Then you have a lot of higher-level wrappers, e.g. pytest-mock.

So it means that every time you make changes to this library, you'll use an account to test that notion-sdk-py is working ?

Only when I write new tests that call the API, or change the calls of an existing test.

You save this account credential locally and test only locally ?

The API key is passed through the environment (12 factors style). Tests are run both locally and through CI with the cassettes. But real API calls to generate the cassettes are only made locally.

I was trying to learn good practices and implement all that on my github but I'm not sure there is an easy and clean way to do this then :/

There's only so much you can do when depending on a tier API you don't have any control over. I wish Notion's team would release a fake API server à la localstack but I don't see that coming soon and I'm not sure I want to do it myself either. :)

from notion-sdk-py.

thomashirtz avatar thomashirtz commented on May 20, 2024

What do you mean by mock the library completely ?
So it means that every time you make changes to this library, you'll use an account to test that notion-sdk-py is working ? You save this account credential locally and test only locally ? I was trying to learn good practices and implement all that on my github but I'm not sure there is an easy and clean way to do this then :/

from notion-sdk-py.

thomashirtz avatar thomashirtz commented on May 20, 2024

Ok thank you for your detailed answer :) !

There's only so much you can do when depending on a tier API you don't have any control over. I wish Notion's team would release a fake API server à la localstack but I don't see that coming soon and I'm not sure I want to do it myself either. :)

Understandable haha

from notion-sdk-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.