ramotion / expanding-collection Goto Github PK

https://github.com/orazz/expanding-collection

As written in the README, the import statement must read import ExpandingCollection. I found, however, that that statement does not work and rather I have to use import expanding_collection.

Hi Developers in Ramotion,

I was reading the example code included, and noticed that you are using extensions a lot. For example in DemoTableViewController, every methods are written as extensions.

Is there any reason/benefit why you are writing it this way?

BR
AnChin

Thx for this cool library. I'm trying to add to my project.

Right now I have an issue with the currentIndex. When I peek at the card, the collectionView.contentOffset.x is 221.5, but when I go to the ExpandingTableViewController and then return, the collectionView.contentOffset.x changes to 221.0. This leads to currentIndex pointing at the previous card.

I guess it could be easily fixed by rounding the result.

When I build the demo application, I get the error

/expanding-collection/Source/Helpers/Constraints Helpers/ConstraintsHelper.swift:77:30: Type of expression is ambiguous without more context

func addScaleToFillConstratinsOnView(view: UIView) {
    [NSLayoutAttribute.Left, .Right, .Top, .Bottom].forEach { attribute in
      (self, view) >>>- { $0.attribute = attribute }
    }
  }

I updated my project to Swift 3 and now this pod doesn't work. Can you please update it ASAP?? If so, when would that be published?

Hi there

First off thanks for a great component.

I need to cater for multiple screen sizes so I have to set the itemSize based on the device type. This works well. However, the change does not filter down to the shadow and as a result. I get an oversized shadow. I've been through the demo and the code and there doesn't seem to be a way to redraw/cater for the shadow.

Please help

Imran

How can I have the first index show instead of the zero index?

How It Shows Up When It Runs:

How I want it to start up like:

How do I achieve the effect of the title label fading out like in your demo project? I've been searching in the code for days but can't find anything that specifically called that animation.

Hey there,

Thank you very much for the great work and your contribution.
I am having a hard time understanding the logic behind archive and unarchive in TransitionDriver. It seems the we are unarchiving right after archiving. Is there any specific reason for this.

fatal error: unexpectedly found nil while unwrapping an Optional value

I am trying to follow the instruction on creating a custom cell. Every time I assign the cell this particular name I get the error in the title. I am probably missing out on something. Help appreciated 👍

When I use this framework from carthage, I am unable to inherit from BasePageCollectionCell. But when I copy the source file directly to my project, everything work fine. When I inherit from BasePageCollectionCell using carthage, I'm just unable to assign the class to the cell.xib. Please fix. Thanks.

The space between the cards is too large for an iPhone 5s, so the user sees only one card. It's not obvious how to interact with the collection in this situation.

On iOS 10 going-to-fullscreen animation starts from wrong point.

In the Readme, I found a couple typos:

• "Licence" => "License"
• "Epanding" => "Expanding"

Best,
-Rex

Can someone help me with integrating this with my app?

Hi there,

is there any sample code using this collection view with dynamic loaded content like from a JSON Rest Api or similar?

thanks in advance

just download Demo and replace picture
image type ‘.jpeg’

Hi There,

Thanks for this module. It was very useful.

In my current application, I created a customView class which will be called from the viewController. I have my delegate and data source methods set in the customView class. When I try to run the application, though I have assigned numberOfItemInSection, the app crashes at this point of line which is being added as an Image along with this issue. Please kindly acknowledge at the earliest

Thank you.

Hi

I m trying to open card cell without clicked the collection cell , I tried to set the value of isOpen true there is strange whiteout screen show first time
Is there any option to show card open in advanced without click on cell

must register a nib or a class for the identifier or connect a prototype cell in a storyboard

Following the instructions and stuck on Create CollectionViewController step #2-3.

I have my custom Collection View Cell with .xib files all linked up (frontContainerView, backContainerView, frontConstraintY, backConstraintY)
Gave the collection view a reusable identifier.

Now I don't understand the next part. From what I am getting is that I don't need to drag in a collection view into the storyboard, but somehow just with the ViewController class this will work.

So I have my ViewController inherited from BasePageCollectionCell. My storyboard has nothing but that ViewController.

I am trying to get this to work. Help would be appreciated, thanks.

How would you be able to add infinite scroll/pagination functionality to collection view to load more content? Has anyone been able to achieve this? Thanks in advance

Any plans for Swift 3 support?

I could not access the Init fund as it is declared in the swift 3 version "internal func Init(_ ...". Had to change it to "public func Init(_ ..." so the it could be reached by my project.

When I have a StatusBar and NavigationBar visible the card jumps on user interactions. Also when I return from the TableViewController the vertical offset is not quite correct.

Is it possible to use this component with StatusBar and NavigationBar visible?

Is there any chance of getting an ExpandingCollectionViewController added as well? I can submit a PR if need be

Hi there.

The first cell is left justified on the main screen on initial load. As soon as I touch the Collection View, the cell moves to the correct position(Center).

Any ideas on how to fix this?

Thanks

Imran

I'm trying to place a button on the back container view of the card. However it does not react to any touch events. Is it somehow covered by the front container?
Can this be changed?

I'm declaring a global var items:[UIImage] = [] and I've a

func loadimages(url: String!) -> [UIImage]{

        let unsafe = url

        var data1 = [UIImage]()



        let bingo = NSURL(string: unsafe!)
        Alamofire.request(.GET, bingo!)
        .validate()
            .responseJSON{ response in
                switch response.result{
                case .Success:

                    let json33 = JSON(data: response.data!)

                    let allImageStrings = json33["response"]["docs"].flatMap { $0.1["imageData"].first?.1}


                    for Bro in allImageStrings{

                        let url = NSURL(string: Bro.string!)
                        let data = NSData(contentsOfURL: url!)!
                        let image = UIImage(data: data)


                        data1.append(image!)

                    }

                  self.items = data1



                    //print(self.items.count)

                case .Failure(let error):
                    print(error)
                }


    }


    return data1

    }

But when I run this,

override func collectionView(collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int {

    print(self.items.count)
    return items.count

    }

Returns 0. How do I make it return the items.count properly? :(

This is a gorgeous framework. The demo project only fits the Iphone screen. How do you set it so it will also fill out an IPAD screen?

The image describing the two containers contains a typo as it sais contaner instead of container

Basically each row you can have ExpandingViewController means tableview each cell there will be a ExpandingViewController where you can scroll inside also .. how to do that with this @ober01

It would be great if scrollViewDidEndDecelerating is open alias, so it could be customized.

Great library! I love this thing. But I noticed something very strange, and didn't quite figure out what's going on. I have a button on the back view, but looks like it's disabled when shown after the first animation. Any idea what might cause this? And how it could be fixed?

I have followed guidance of this library, and have faced second problem.
The first one is for connecting frontViewContainer, backViewContainer, frontConstraintY, backConstraintY, and I had no solution for that #34 #26 .
But I was able to figure it out with copy/pasting the demo cell from demo project.

Now the second problem is, I have defined didSelectItemAt method, but it's not calling all the time.

func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
        guard let cell = collectionView.cellForItem(at: indexPath) as? MyCollectionViewCell, currentIndex == indexPath.row else { return }

        cell.cellIsOpen(!cell.isOpened)
}

The viewcontroller is inherited from ExpandingViewController, and MyCollectionViewCell is inherited from BasePageCollectionCell.
I'm not sure why does this happening.

Any help would be appreciated.
Thanks

Hello,
How can I make the paging cards vertical instead of moving horizontal when swiping.
This is in the demo.

In the demo example provided, is there a way to remove the background view that stacks on top of the DemoTableViewController?

I was having an issue with cell selection. After the collection view was scrolled, the next visible cell's frame was being changed, and tapping on the cell only successfully called the didSelectItem function in a much smaller frame than the full cell.

I noticed that this was happening due to the following code:

extension ExpandingViewController {
  
  public func scrollViewDidEndDecelerating(_ scrollView: UIScrollView) {
    let indexPath = IndexPath(row: currentIndex, section: 0)
    if case let currentCell as BasePageCollectionCell = collectionView?.cellForItem(at: indexPath) {
      currentCell.configurationCell()
    }
  }
}

When I commented this code out, the collection view cells began to behave properly after scrolling. That is to say, the item selection was happening within the proper bounds, and they were not changed.

I am writing this issue to ask if there was any reason to use the currentCell.configurationCell() call, since it seems to be manipulating the frames of the cell's view instead of working with auto layout constraints.

I'm having an issue whereby when I'm trying to close the pushed view controller, it is animating down to the center (as if the cell is closed) and then upon completion the cell snaps and jolts back to being open again. How can I override it so that the cell is always closed, when you exit the pushed VC?

Looking up and down throughout the code, and whilst it's a beautiful piece of work... it is a nightmare to find out what is calling that last change.

Can i pass data between view controllers

pod 'expanding-collection', '~> 1.0.4'
unable to download

Hi! Ramotion

I found a bug, when I set ItemWidth > 270 ,some problem will happe， I can't fix it, I need your help! Thanks!!!

My English is so bad, I hope you can understand what I mean. Thank you!

If you scroll to fast when exiting the DemoTableViewController the method gets called more than once which for some reason produces a nil while unwrapping.

Screenshot just to display that it occurs.

Tested on iPhone 6 Plus (iOS 8.3)

I just noticed this small movement on the bottom of the UIView, once you see it for the first time it is quite noticeable later. I am using version 0.3.2 of Expanding-Collection, is there any why to fix this on Swift 2.3?
I Have Not Modified The Code In Any Way
It happens right at the end after moving to another collection view

Example Below: (Very Small Movement In The Bottom)
I compressed the two video files showing the problem into a zip file below.
Two Video Examples.zip

I could not access the func Init(...) as it is declared in the swift 3 version "internal func Init(_ ...". Had to change it to "public func Init(...)" so it could be reached by my project.

I have checked #26 but there is no solution for this issue.
Please help me how can I fix this problem.

Hi,
For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

In list of cards i have added buttons on background view when i open first card buttons are not accessible but when i scroll some items and come back to the first card then sometimes buttons get activated but not always.