GithubHelp home page GithubHelp logo

Comments (4)

marek-mikula avatar marek-mikula commented on May 10, 2024 2

@diego-ninja Hello,

I ran to the same problem today. I resolved the issue using patches in composer. Use this plugin https://github.com/cweagans/composer-patches and as a patch use your PR. I used it too and it works.

At least something before this issue gets resolved. :)

from conventional-commits.

ramsey avatar ramsey commented on May 10, 2024

Hi, thanks for submitting this!

Do you mean Symfony 5 or Symfony 6?

Here's what I see in Symfony 5: https://github.com/symfony/console/blob/6c6664efbf6fc5f22bc6cbcb03616dc7f1eb6e6f/Input/InputInterface.php#L29

And here's what I see in Symfony 6: https://github.com/symfony/console/blob/faf53e783e67847aff7de5ba73d9be76b7d4d65c/Input/InputInterface.php#L27

So, I think your changes are to support Symfony 6, right?

Unfortunately, this means that I'll have to drop Symfony 5 support, which might cause problems with others using this package. I'll need to give some thought to this.

from conventional-commits.

diego-ninja avatar diego-ninja commented on May 10, 2024

Yeah, I mean Symfony 6, sorry for the typo. I will modify pull request.

from conventional-commits.

ramsey avatar ramsey commented on May 10, 2024

Thanks for reporting. This is fixed in version 1.3.1.

from conventional-commits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.