[0.9] Bundles with no matching targets makes Content objects to be constantly recreated about fleet

[aruiz14]

Additional QA

Solution

I moved the code that stores the encoded manifests (ensures that a Content object exists with that content) after the targets are calculated, skipping that step if no targets were found.

Testing

• No regressions should be added due to this change.
• Creating a bundle whose targetCustomizations (in fleet.yaml) match no clusters should prevent the relevant Content objects from being constantly created and deleted.

[thehejik]

Test report

This seems to be fixed in fleet:103.1.3+up0.9.3-rc.2 on rancher v2.8-head

On fleet-0.9.2 I was unable to verify that the resource is getting deleted by a cleanup process and recreated automatically afterwards but I verified the resources are not created at all when the target doesn't exist on fleet-0.9.3 so it should prevent the described problem.

Before:

• I could see on previous fleet-0.9.2 version that even when a gitRepo is pointing to a non-existing target its contents.fleet.cattle.io resource is always created and recreated when deleted manually.

After:

• On the other hand, on fleet-0.9.3 the resource is only created when the target exists.

Note:
I wasn't using fleet.yaml and targetCustomizations but only rancher UI to select desired Target for my testing gitRepo (No Clusters / All clusters in the Workspace).

Commands used for testing:

$ kubectl get contents.fleet.cattle.io  -A -w
# To verify content of contents.fleet.cattle.io resource
$ kubectl get contents.fleet.cattle.io  s-f96aa690fa5e38da8499e2a326b688a0db2c9263d88cfd85a243948f1fb41 -o jsonpath='{.content}' | base64 -d | gunzip -
# To delete the content resource
$ kubectl delete contents.fleet.cattle.io  -A s-f96aa690fa5e38da8499e2a326b688a0db2c9263d88cfd85a243948f1fb41

[thehejik]

Verified also with following targetCustomizations and doNotDeploy: true in fleet.yaml:

targetCustomizations:
- name: dev
  doNotDeploy: true
  clusterSelector:
    matchLabels:
      env: dev

Before:

(fleet:103.1.2+up0.9.2)

• the contents resource for testing gitRepo is getting created and deleted periodically when the target doesn't exist:

$ kubectl get contents.fleet.cattle.io -w
NAME                                                              AGE
s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539   0s
s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539   8m25s
s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539   0s
s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539   8m25s

$ kubectl logs -lapp=fleet-controller -n cattle-fleet-system -f
time="2024-04-12T08:57:32Z" level=info msg="Marking orphaned content[s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539] for deletion"
time="2024-04-12T09:02:32Z" level=info msg="Deleting orphaned content[s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539]"
time="2024-04-12T09:12:32Z" level=info msg="Marking orphaned content[s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539] for deletion"
time="2024-04-12T09:17:32Z" level=info msg="Deleting orphaned content[s-503ff6ee308f9d83d835dfb233390776c839d6b1897395aea0e8cbb2c4539]"

After:

(fleet:103.1.3+up0.9.3-rc.3)

• the contents resource is not created at all when the target doesn't exist nor when the target exists but doNotDeploy: true is set.
• Once I added env: dev label to my cluster and pushed doNotDeploy: false to my testing repo the contents resource has been created.

All good, closing.