GithubHelp home page GithubHelp logo

Add CI to frameworks repos about rancher HOT 4 CLOSED

MKlimuszka avatar MKlimuszka commented on September 24, 2024
Add CI to frameworks repos

from rancher.

Comments (4)

MKlimuszka avatar MKlimuszka commented on September 24, 2024

I will split this up into sub tickets.

from rancher.

cbron avatar cbron commented on September 24, 2024

I'm going to close this old ticket as dupe now: rancher/tasks#201

from rancher.

tomleb avatar tomleb commented on September 24, 2024

I'm going to close this old ticket as dupe now: rancher/tasks#201

I see that issue lists other things like golangci-lint, go fmt and go mod verify checks. For the purpose of #44970 we're looking at just adding go test. This will at least gives us more confidence when PRs are opened (especially for PRs from renovate).

When we migrate to GHA proper, or perhaps later, we should revisit which ones are missing. Some are non-trivial to add, for example:

  • apiserver lint fails for a few reasons, like not checking an error. Fixing this should go through the usual process to reduce risk of regression. (Assuming we want to actually add the error check and not just explicitely ignore it)
  • Same for remotedialer (github issue not yet created).

Note that if golangci-lint runs and is trivial to fix then I'll add it as well as I go through those missing.

from rancher.

MKlimuszka avatar MKlimuszka commented on September 24, 2024

GHA migration will cover the scope of this ticket.

from rancher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.