[BUG] Helm charts in downstreamclusters fail to sync in airgapped 2.8.3 about rancher

[abinet]

It seems like a bug introduced in new version.
Workaround which worked for us is to set configuration in downstream clusters manually by

kubectl patch settings.management.cattle.io system-catalog --type=merge --patch 'value: "bundled"'

[Trekky12]

I can confirm this and because the error messages reads Ensure failure I assume the error was somewhere introducted in:

rancher/pkg/catalogv2/git/download.go

Lines 11 to 34 in 904c2fb

	func Ensure(secret *corev1.Secret, namespace, name, gitURL, commit string, insecureSkipTLS bool, caBundle []byte) error {
	git, err := gitForRepo(secret, namespace, name, gitURL, insecureSkipTLS, caBundle)
	if err != nil {
	return fmt.Errorf("ensure failure: %w", err)
	}
	// If the repositories are rancher managed and if bundled is set
	// don't fetch anything from upstream.
	if IsBundled(git.Directory) && settings.SystemCatalog.Get() == "bundled" {
	return nil
	}
	if err := git.clone(""); err != nil {
	return fmt.Errorf("ensure failure: %w", err)
	}
	if err := git.reset(commit); err == nil {
	return nil
	}
	if err := git.fetchAndReset(commit); err != nil {
	return fmt.Errorf("ensure failure: %w", err)
	}
	return nil

The git history is here:
https://github.com/rancher/rancher/commits/904c2fb091373c12951a0c54d8ba10969d887369/pkg/catalogv2/git/download.go

[abinet]

we have same issue with air-gapped 2.8.4 installation as well

[LeonSchumacher]

Hi i have the same issue with 2.8.3 also airgapped installation.

[dfencegit]

Same here worked at 2.8.1 and now broken after upgrade to 2.8.4. Looks like new clusters deployed from 2.8.4 work seem ok for ~20 minutes then the Repositories fail to update and the fall into error state. This issue does not impact the local cluster.

[dfencegit]

Thanks, that worked for us, brought offline charts back.

[jdbaudean]

I hit the same bug in 2.8.4, that patch worked for me as well. Does anyone know if this is still present in 2.8.5?

[LsM97]

Can confirm the issue still persists in 2.8.5 for us

[sammasamadhi]

Thanks, that worked for us