GithubHelp home page GithubHelp logo

Comments (7)

sohailsomani avatar sohailsomani commented on May 13, 2024

+1. I patched it in my build as well.

from botan.

sohailsomani avatar sohailsomani commented on May 13, 2024

FYI, you can do something like this in a common header:

#ifdef _MSC_VER
#  define BOTAN_NOEXCEPT
#else
#  define BOTAN_NOEXCEPT noexcept
#endif

And then replace noexcept with BOTAN_NOEXCEPT in the codebase.

from botan.

patlecat avatar patlecat commented on May 13, 2024

The noexcept is one of the easiest "lacks" of MSVC to deal with: Just use the official macro _NOEXCEPT which under MSVC2013 is defined in yvals.h .

from botan.

webmaster128 avatar webmaster128 commented on May 13, 2024

Most if the work is done in c84b150. There is only one occurrence of plain noexcept left in src/lib/math/ec_gfp/curve_gfp.h as pointed out in #56.

from botan.

neusdan avatar neusdan commented on May 13, 2024

Can be closed now. #56

from botan.

patlecat avatar patlecat commented on May 13, 2024

Excellent, thanks :)

from botan.

webmaster128 avatar webmaster128 commented on May 13, 2024

@LightBender @randombit Can someone close this one please to keep issues list clean? Thanks!

from botan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.