Interface Setter Methods Not Being Intercepted about byte-buddy

[raphw]

It is because Byte Buddy figured out that another method defined on the Object type is more suitable for binding. You can restrain this by defining:

MethodDelegation.to(new GeneralInterceptor(new ProxyedInterfaceDelegate(10L)))
                        .filter(not(isDeclaredBy(Object.class)))

to tell the method delegation not to consider the Object type's methods. However, this default behavior is a little bit unintuitive. I'll see if I find a more intuitive default for a future version without breaking the general idea of the MethodDelegation's binding algorithm.

[saden1]

Awesome! I was thinking .method(isDeclaredBy(type)) would filter out object methods.

Thanks for the quick turnarounds and this fantastic library.

[raphw]

For clarification: There are two filters involved:

1. The filter for the methods of the dynamically generated type. Saying: When you define that you want to subclass(type), you are further saying you want to override methods that match isDeclaredBy(type) and let the others alone.
2. The filter for the MethodDelegation where you are constraining to methods of your GeneralInterceptor that are not(isDeclaredBy(Object.class)), i.e. the intercept method.

In Byte Buddy 0.5, I added an additional AmbiguityResolver that automatically selects the method out of two that is declared by the most specific type which is a better default. This behavior bothered me before, I think this is a better approach for the future. Expect a release of this version sometime the year-shift.

PS: There is a bug fix release 0.4.1 available that allows you to use the InvocationHandlerAdapter if you want to. Its now also on Maven Central.

[saden1]

Got it. I am already using the latest 0.4.1 release. Thank you so much.

[saden1]

I just want to add that having to exclude Object class methods is quite problematic. It is preventing me from delegating calls to equals(...) method to an underlying implementation. Hopefully the new solution will allow me to delegate methods like equals.

[raphw]

It does! It just prefers methods of a subtype without discarding them. You are also always free to configure your own AmbiguityResolver or to rearrange the existing ones. If you want to delegate to equals(Object), it however sounds like you might be able to use the more efficient Forwarding instrumentation which always delegates to a method with identical signature.

When filtering, you can always include the equals method by for example specifying not(isDeclaredBy(Object.class)).or(named("equals")).

[saden1]

Excellent!