GithubHelp home page GithubHelp logo

Comments (3)

fsfod avatar fsfod commented on May 26, 2024

Snapshot creation is lazy based on the last IR instruction with side effects between guard instructions so most the time you will end up duplicating some stuff in a side trace. For the sample based Lua line IR profile markers a snapshot is always created for each one I think.

If you have too many live values going across to a side trace you can endup with the the dreaded NYI register coalescing too complex abort and the trying to JIT the uncompiled trace exit to to interpreter will fail with the same error most the time.

from raptorjit.

lukego avatar lukego commented on May 26, 2024

@fsfod The duplicate work should only be for instructions after the last snapshot though, right? I am surprised that the side trace took exit 2 but is repeating work that the parent did in snapshot 0. This seems redundant, no?

(Or maybe that work is being repeated for a different reason e.g. the TBAR invalidates the earlier guard results?)

from raptorjit.

lukego avatar lukego commented on May 26, 2024

@fsfod I tested removing the global = 0 line from the parent. Then there is no TBAR barrier but the child is still repeating all of the same instructions to locate the hashtable slot.

Just on a first casual inspection of the code it looks like side traces inherit values from the parent snapshot via lj_snap_replay() but nothing more? So guards and constant hashtable slot lookups etc will be repeated? (Opportunity for more aggressive de-duplication like LOOP opt?)

from raptorjit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.