Comments (5)
Argh! I def. didn't want that. I actually say that in my inital blog post on medium. That you can use :>
to make sure the first argument is interpreted as the props!
I accepted the PR without much thought since I have since moved on from Clojure. I'd certainly accept a PR restoring the old functionality. Even though I don't like flip/flopping on this behavior. :/
Not sure what to do here. Either way sucks.
from hicada.
Thinking about it. Gonna leave it like that. Breaking it again would suck for the 0.1.9 users. Better only break it once than twice, right?
But glad that there is workaround, that was actually one bit motivation: Don't provide a macro, just a function and let users configure the behavior as much as they want.
So "won't fix" it is. Thanks for letting me know. And let me know if you'd like commit access to hicada... ;)
from hicada.
After thinking a bit about this, I still think the revert is a better way to proceed. Because the :>
handler was the unique approach for passing props dynamically hicada has, with the current situation we have the :>
handler and the default one [:somekeyword
are synonyms, leaving hicada without any dynamic extensibility/usage. Additionally, the default (previous behavior was documented) and the new one not.
And you of the past was right exposing the building block and not the final api was the right decision.
PD: i'm gladly can take care of the maintenance of hicada, just give me permissions to repository and if you prefer the clojars permission to hicada group (if not, i can publish it under funcool organization also...)
from hicada.
You're the boss now, so feel free to revert it :)
I also gave you permission to the clojars, let me know if you need more access.
from hicada.
Nice @rauhs, Thank you.
from hicada.
Related Issues (13)
- Hicada to HTML String ? HOT 2
- Attrs type hint HOT 10
- trouble compiling project HOT 3
- Should `compile-html` walk everything? HOT 1
- Use with Rum? HOT 4
- Private discussion HOT 1
- Isomorphic rendering? HOT 8
- Optional props for :> HOT 1
- Preserve clojurescript objects in props HOT 3
- Incorrect result on compiling `cond` with more than 4 conditions. HOT 2
- Server side rendering HOT 1
- Deploy a new version (> 0.1.8) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hicada.