GithubHelp home page GithubHelp logo

The 0.1.9 causes regression about hicada HOT 5 OPEN

niwinz avatar niwinz commented on July 19, 2024
The 0.1.9 causes regression

from hicada.

Comments (5)

rauhs avatar rauhs commented on July 19, 2024

Argh! I def. didn't want that. I actually say that in my inital blog post on medium. That you can use :> to make sure the first argument is interpreted as the props!

I accepted the PR without much thought since I have since moved on from Clojure. I'd certainly accept a PR restoring the old functionality. Even though I don't like flip/flopping on this behavior. :/

Not sure what to do here. Either way sucks.

from hicada.

rauhs avatar rauhs commented on July 19, 2024

Thinking about it. Gonna leave it like that. Breaking it again would suck for the 0.1.9 users. Better only break it once than twice, right?

But glad that there is workaround, that was actually one bit motivation: Don't provide a macro, just a function and let users configure the behavior as much as they want.

So "won't fix" it is. Thanks for letting me know. And let me know if you'd like commit access to hicada... ;)

from hicada.

niwinz avatar niwinz commented on July 19, 2024

After thinking a bit about this, I still think the revert is a better way to proceed. Because the :> handler was the unique approach for passing props dynamically hicada has, with the current situation we have the :> handler and the default one [:somekeyword are synonyms, leaving hicada without any dynamic extensibility/usage. Additionally, the default (previous behavior was documented) and the new one not.

And you of the past was right exposing the building block and not the final api was the right decision.

PD: i'm gladly can take care of the maintenance of hicada, just give me permissions to repository and if you prefer the clojars permission to hicada group (if not, i can publish it under funcool organization also...)

from hicada.

rauhs avatar rauhs commented on July 19, 2024

You're the boss now, so feel free to revert it :)

I also gave you permission to the clojars, let me know if you need more access.

from hicada.

niwinz avatar niwinz commented on July 19, 2024

Nice @rauhs, Thank you.

from hicada.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.