GithubHelp home page GithubHelp logo

Light Code Feedback about patch-2.22-launcher HOT 3 CLOSED

ravo92 avatar ravo92 commented on September 28, 2024 1
Light Code Feedback

from patch-2.22-launcher.

Comments (3)

dginovker avatar dginovker commented on September 28, 2024 1

Looks great! Error.log will work great for people immediately closing and not reading the error message too.

Keep up the good work!

from patch-2.22-launcher.

Ravo92 avatar Ravo92 commented on September 28, 2024

Thank you for this heavy valuable feedback! I will keep this issue open as long ther are basic failures and mistakes in pattern.

from patch-2.22-launcher.

Ravo92 avatar Ravo92 commented on September 28, 2024

1 + 2
I changed the exe startup behaviour to: "Always start updater.exe when clicked on wrong exe". I also changed to double dash:
676f650

3
Thank you :D

4
I removed the comments, I'll switch for the new and next windows to .net maui were the dpi scaling problem shouldn't be that big of an issue. 7930275

5
I added a try-catch block there with a null-return if error and logging the caught error. I know what returning null is the worst you can do, but i have no idea for now, how to make this method more clean. 678b51b

6
Thank you - I still made it better, since there is a "IsNotNull" Boolean, which I only used once and then proceeded with "!= null" so wasn't perfect yet. 0bb358d

from patch-2.22-launcher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.