GithubHelp home page GithubHelp logo

Status text position about i3lock-color HOT 12 CLOSED

raymo111 avatar raymo111 commented on June 11, 2024
Status text position

from i3lock-color.

Comments (12)

PandorasFox avatar PandorasFox commented on June 11, 2024 3

I'll definitely look into it after I do some other refactoring this weekend

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024 1

oh god, this refactor is gonna probably break a decent amount of stuff in people's scripts (decoupling this pretty much means I need to rearrange a lot of code [which I've needed to, anyways]), so this is gonna be.... interesting....

On the bright side, the unlock indicator stuff is no longer gonna be one gigantic function, so that's a plus (and has needed to be done for a long while coming).

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024 1

Alright, I've pushed this to master and it should be working fine.

I think that the default I use for the status text positioning should be "right", in that the defaults and stuff should look the same. Some people might have to adjust the positioning on their rices a bit, but that was a bit unavoidable :(

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024

It'll require a bit more work since it needs to be decoupled from the regular ring indicator (currently, on the bar indicator, there's no way to see the status text).

I'll have to poke at it a bit later, and it's been on my mind, but it's more annoying to implement than the rest.

from i3lock-color.

Trollwut avatar Trollwut commented on June 11, 2024

Ah ok, so it's not a thing for the near future. :)

Was asking because I currently use betterlockscreen, which bases on i3lock-color and it would be nice to have the status text added in that "textbox" instead of only one letter in that small circle :D

from i3lock-color.

AUTplayed avatar AUTplayed commented on June 11, 2024

mod position would also be nice, because if the radius is < 30 you can't really see the "caps lock" warning

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024

Yeah, I need to work on this soon, but I ended up being ill for most of December, and now school is starting back up again p:

This is something I've been meaning to do for a while (but have been hesitant to do so, because it'll make this fork a bit more of a hard fork from upstream / harder to maintain), so if I'm going to be doing this, I'll be doing a decent amount of refactoring to make this more maintainable.

from i3lock-color.

AUTplayed avatar AUTplayed commented on June 11, 2024

sure, take your time, just wanted to mention it :)

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024

This is in dev as of 6b94376

I feel like there's probably a few rough edges to this refactor (since I did this in pretty much one shot), but it was mostly just copy/pasting a bunch of code around (so maybe it's fine).

(If you don't tag before building, like usual, it'll build a debug build that'll be a lot slower).

I'll poke at it more tomorrow to make sure that there's no regressions, since a lot of stuff got moved around, and a few things may have fallen between some cracks.

(also of note, a few things got broken for the sake of making stuff nicer to work with, so I'll need to update the manpage before pushing anything to master)

from i3lock-color.

AUTplayed avatar AUTplayed commented on June 11, 2024

cool thanks, but I think some things are still missing in the manpage, because using cw or ch in --timepos breaks the whole positioning. Also statuspos, modifpos and indpos are just generally missing in the man page.

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024

Ah, yeah, cw/ch aren't variables anymore. I'll go touch those up in a bit.

The manpages really need a gigantic overhaul/redo, but I haven't really had the time to sit down and redo all the docs P:

from i3lock-color.

PandorasFox avatar PandorasFox commented on June 11, 2024

(Gonna close this now since I do think this is working properly now)

from i3lock-color.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.