LeakSanitizer: detected memory leaks about i3lock-color

[PandorasFox]

There'll be some leaks reported in Valgrind.

There's some discussion in i3#168 - this is sorta intentional. We can do some cleanup at exit, but it complicates the code and doesn't really matter that much, since the OS handles that memory anyways. There's no leaks that occur more than once (i.e. all the leaked memory is only leaked once, so it's less of a leak and more of a "not bothering to clean up memory at exit, to keep the code cleaner/easier to maintain").

[PandorasFox]

This was fixed as of ddfc62f and is actually an upstream issue (see i3#167). Make sure you've grabbed the latest release / are building from the latest source.

[PandorasFox]

Double checked against master:

🦊  ./i3lock -n -e -f -i /tmp/i3lock-color_downscale.png --bar-indicator --bar-orientation=horizontal --bar-direction=1 --bar-position=1080 --bar-step=10 --bar-periodic-step=10 --bar-max-height=10 --bar-base-width=10 --bar-width=320 --bar-color=#00000000 --keyhlcolor=#64abbfff --bshlcolor=#d26937ff --ringvercolor=#edb443ff --ringwrongcolor=#c23127ff --clock --force-clock --timecolor=#99d1ceff --datecolor=#99d1ceff --timefont='Source Code Pro' --datefont='Source Code Pro' --timesize=80 --datesize=20 --datestr=%d/%m/%Y
./i3lock: unrecognized option '--timefont=Source Code Pro'
i3lock: Syntax: i3lock [-v] [-n] [-b] [-d] [-c color] [-u] [-p win|default] [-i image.png] [-t] [-e] [-f]
Please see the manpage for a full list of arguments.

Those args have been changed to --time-font and --date-font, so double check you're using the latest version, then see if the issue still occurs.

[Helvethor]

Switching to the git repo did it. Thanks

Building i3lock in Solus 3 and running it without arguments produces some leaks.

Output of valgrind -v --leak-check=full ./x86_64-pc-linux-gnu/i3lock:

https://hastebin.com/uyukimazin

I built from both the latest tag (2.10.1-2-c) and the master branch.