duration overwritten about elysia-rate-limit

[rayriffy]

No that's not the behavior of rate limit at all. Rate limiting should be counted by time window, what you're asking right now is to give user a time out after certain request which is no longer a rate limiting anymore.

Thinking this scenario, with rate limit of 10 request with duration of 100 seconds

1. (0 sec) Make 2 requests
2. (400 sec) Make 7 request
3. (800 sec) Make 1 request
4. (801 sec) Make 1 request, get rate limited and waiting for 100 seconds
5. (901 sec) Make 1 request

This is 900 seconds time window, not 100 seconds

[doroved]

Apparently, duration should be passed to the increment function

elysia-rate-limit/src/services/plugin.ts

Line 45 in 098e4c7

const { count, nextReset } = await options.context.increment(clientKey!)

[doroved]

Great, thank you.

[doroved]

@rayriffy , I think that Ratelimit-Reset should start counting after the requests run out.
Right now it triggers after the first request, which doesn't seem logical.
What do you think about this?

rateLimit({
  max: 10,
  duration: 100 * 1000
})

Ratelimit-Limit:
10
Ratelimit-Remaining:
7
Ratelimit-Reset:
75

[doroved]

No that's not the behavior of rate limit at all. Rate limiting should be counted by time window, what you're asking right now is to give user a time out after certain request which is no longer a rate limiting anymore.

Thinking this scenario, with rate limit of 10 request with duration of 100 seconds

1. (0 sec) Make 2 requests
2. (400 sec) Make 7 request
3. (800 sec) Make 1 request
4. (801 sec) Make 1 request, get rate limited and waiting for 100 seconds
5. (901 sec) Make 1 request

This is 900 seconds time window, not 100 seconds

Thanks for the explanation, indeed, I hadn't thought of that)

In order not to create a new issue, let me ask here.
I see that the ...rest is passed to the generator.

elysia-rate-limit/src/services/plugin.ts

Line 41 in fb23a8d

clientKey = await options.generator(request, app.server, rest)

Earlier you added derived support to the generator and showed an example using elysia-ip.
I would like to be able to access cookie, path etc from Elysia in the generator. Is there any way we can throw these into the generator?

[rayriffy]

cookies are just http header, you can intercept and parse them via request

[doroved]

cookies are just http header, you can intercept and parse them via request.

Yes, I just didn't want to write my own parser function) Ok