GithubHelp home page GithubHelp logo

Comments (2)

MichaelChirico avatar MichaelChirico commented on July 19, 2024

Thanks for tracking these down! Yes please switch to ngettext(). So far they haven't been sussed out because Mandarin doesn't really have plural forms, so translating there is easy without using ngettext().

from data.table.

MichaelChirico avatar MichaelChirico commented on July 19, 2024

For the C messages, we don't have any ngettext() usage there yet, so please ensure we are properly set up to start doing plural translations there:

  1. Make sure the package compiles and can pass tests, obviously :)
  2. Make sure the recommended translation workflow is picking these new strings up

xgettext -o /dev/stdout ./*.c \
--keyword=Rprintf --keyword=error --keyword=warning --keyword=STOP --keyword=DTWARN --keyword=Error --keyword=DTPRINT --keyword=snprintf:3
## (b) Update R template file: src/R-data.table.pot
## NB: this relies on R >= 4.0 to remove a bug in update_pkg_po
Rscript -e "tools::update_pkg_po('.')"
# 2) Open a PR with the new templates & contact the translators
# * zh_CN: @hongyuanjia
## Translators to submit commits with translations to this PR
## [or perhaps, if we get several languages, each to open
## its own PR and merge to main translation PR]
## 3) Check validity with tools::checkPoFiles("zh_CN")
## 4) Compile the new .mo binary files with potools::po_compile()

At a glance, I don't think it will -- I don't see ngettext() mentioned there.

from data.table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.