Unexpected recursive context inclusion exception about rdflib

[wallberg]

The problem is that fails1.jsonld.json references both https://w3id.org/ro/crate/1.1/context and https://w3id.org/ro/terms/workflow-run, but https://w3id.org/ro/terms/workflow-run itself also references https://w3id.org/ro/crate/1.1/context.

$ curl -s -D - -L --header "Accept: application/ld+json, application/json;q=0.9, */*;q=0.1" https://w3id.org/ro/terms/workflow-run
HTTP/1.1 303 See Other
Date: Fri, 10 May 2024 13:33:26 GMT
Server: Apache/2.4.29 (Ubuntu)
Access-Control-Allow-Origin: *
Location: https://www.researchobject.org/ro-terms/workflow-run/context.json
Content-Length: 347
Content-Type: text/html; charset=iso-8859-1

HTTP/2 200
server: GitHub.com
content-type: application/json; charset=utf-8
last-modified: Tue, 07 May 2024 10:47:00 GMT
access-control-allow-origin: *
etag: "663a06a4-4fa"
expires: Fri, 10 May 2024 12:53:33 GMT
cache-control: max-age=600
x-proxy-cache: MISS
x-github-request-id: 66BE:12EDA7:4B3666:5B7E8D:663E1674
accept-ranges: bytes
age: 102
date: Fri, 10 May 2024 13:33:26 GMT
via: 1.1 varnish
x-served-by: cache-ewr18145-EWR
x-cache: HIT
x-cache-hits: 0
x-timer: S1715348006.225059,VS0,VE2
vary: Accept-Encoding
x-fastly-request-id: 1182bf956578eccfb9b7d97fcb3c094c8b2465d6
content-length: 1274

{
    "@context": [
        "https://w3id.org/ro/crate/1.1/context",
        {
            "ParameterConnection": "https://w3id.org/ro/terms/workflow-run#ParameterConnection",
            "ContainerImage": "https://w3id.org/ro/terms/workflow-run#ContainerImage",
            "DockerImage": "https://w3id.org/ro/terms/workflow-run#DockerImage",
            "SIFImage": "https://w3id.org/ro/terms/workflow-run#SIFImage",
            "connection": "https://w3id.org/ro/terms/workflow-run#connection",
            "sourceParameter": "https://w3id.org/ro/terms/workflow-run#sourceParameter",
            "targetParameter": "https://w3id.org/ro/terms/workflow-run#targetParameter",
            "md5": "https://w3id.org/ro/terms/workflow-run#md5",
            "sha1": "https://w3id.org/ro/terms/workflow-run#sha1",
            "sha256": "https://w3id.org/ro/terms/workflow-run#sha256",
            "sha512": "https://w3id.org/ro/terms/workflow-run#sha512",
            "environment": "https://w3id.org/ro/terms/workflow-run#environment",
            "registry": "https://w3id.org/ro/terms/workflow-run#registry",
            "tag": "https://w3id.org/ro/terms/workflow-run#tag",
            "containerImage": "https://w3id.org/ro/terms/workflow-run#containerImage"
        }
    ]
}

[wallberg]

What I wonder is why encountering the same context a second time needs to raise an exception at all? Why can't we simply skip it?

I tried replacing the exception with a skip, return None, at https://github.com/RDFLib/rdflib/blob/main/rdflib/plugins/shared/jsonld/context.py#L474-L475, and all tests pass other than the one expecting the exception.