Cannot build against current librsync version, 2.0.2 about rdiff-backup

[tom-ch1]

I can confirm that this patch works

[nffdiogosilva]

@mhsmith did you solve this? The patch doesn't work for me

[mhsmith]

I haven't pursued this problem and I never tested the patch: I only linked to it in case it was useful to others.

[ottok]

Fixed for Debian in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928885#28

[ericzolf]

I'm a bit confused because the link to Debian only shows a change of librsync-dev version but nothing more. Furthermore the current code in the repository has already (more or less) the patch suggested initially, already required for version 1.0 of librsync. And the patch still involves MD4 as default hash (RS_MD4_SIG_MAGIC vs. RS_BLAKE2_SIG_MAGIC).

I have the impression that this issue could be closed (but I don't have a librsync2 library to check).

[ottok]

Here you can find an overview of rsync-backup in Debian: https://tracker.debian.org/pkg/rdiff-backup

Here are the packaging sources: https://salsa.debian.org/python-team/applications/rdiff-backup

Here are the fixes:

• https://salsa.debian.org/python-team/applications/rdiff-backup/commit/2c06400c1dc4512506dc9854caa6374f71e88ef3
• https://salsa.debian.org/python-team/applications/rdiff-backup/commit/29b7b904891c03fa14baa9c83cf9a3fb4dd7f405

I will upstream all of these once the Python 3 branch is merged and master is good to go for further developments.

[ericzolf]

I'm pretty sure this is fixed in my branch and can be closed. For reference, I have created #47 for the introduction of Blake2 as a possible more secure algorithm than MD4.

[ottok]

I can also confirm that building agains librsync2 works with latest master.

Note that I also filed #56

[ericzolf]

Also confirmed as I built on Windows, so we can close this issue.