GithubHelp home page GithubHelp logo

Comments (12)

ericzolf avatar ericzolf commented on June 12, 2024

Few comments from me:

  • yes we need CI/CD!
  • Flake8/PEP8 - yes, please! (the current tabs are ugly and killing my editor) - my next task after Python3 is merged would be to fix all files in this regard.
  • regarding the current tox setup - my impression is that many things are tested multiple times which cost time, we might want to clean this to optimize waiting time at merge time but can be a 2nd step
  • it would be nice to have a test coverage measurement tool (I think it's not too bad, but actually no clue)

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

Yes, code coverage is a good idea and it should be possible to have with Tox (see e.g. https://www.rfk.id.au/blog/entry/testing-better-coverage-tox/).

I have now activated https://travis-ci.org/rdiff-backup/rdiff-backup but there is no real .travis.yml file done yet.

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

First PR filed as #96

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

Second step will be running full Tox suite. WIP at https://github.com/rdiff-backup/rdiff-backup/tree/feature/travis-ci-tox

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

I have been playing around with different approaches to Travis-CI at https://travis-ci.org/rdiff-backup/rdiff-backup/builds using just one big job, or a matrix, or stages. I am not sure what route to take here. Does anybody have comments? @ikus060 maybe?

from rdiff-backup.

ikus060 avatar ikus060 commented on June 12, 2024

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

I think I will settle with this "user experience":

image

image

from rdiff-backup.

ericzolf avatar ericzolf commented on June 12, 2024

The steps look good to me, without exactly knowing what is behind each of them. Are you able to test each Python version from 3.5 till 3.8?

from rdiff-backup.

ottok avatar ottok commented on June 12, 2024

You can see it at https://travis-ci.org/rdiff-backup/rdiff-backup/builds and followg the links to the commits or view the whole WIP branch at https://github.com/rdiff-backup/rdiff-backup/tree/feature/travis-ci-tox

ATM the goal is just to get the tests pass so we can prevent new regressions from sneaking in, and then we can start to expand the tests, the Python versions and the platforms later on.

from rdiff-backup.

ikus060 avatar ikus060 commented on June 12, 2024

Could we close this ticket ? Looking at the current Travis pipeline everything is good to me. If anything is missing we should probably create a separate tickets that are more specific.

from rdiff-backup.

ericzolf avatar ericzolf commented on June 12, 2024

I think we should first add at least all relevant versions of Python (3.5 to 3.8) before we do this. It's a small thing, adding other platforms and the automated generation of binaries would need to go into another issue. What do you think?

from rdiff-backup.

ikus060 avatar ikus060 commented on June 12, 2024

ok, I will start working on travis build to add other version. But seriously, if it's not working for 3.5 or 3.6, I'm fine to only support py3.7.

  1. adding other platforms see #105 should cover Windows
  2. automated generation of binaries, just created #188

from rdiff-backup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.