npm up - peerinvalid error. about react-router-bootstrap

[dozoisch]

thats seems like a bug in npm u_U 0.13.x and 0.13 is pretty much the same unless react-0.14 is out and I didn't see that!

[mathieumg]

Indeed, they both highlight 0.13.0 through 0.13.3 on http://semver.npmjs.com/

[AlexKVal]

unless react-0.14 is out

indeed

[AlexKVal]

anyway I gave it more thought..
the clean installation works fine, I'm closing.

$ rm -rf node_modules
$ npm run i

[AlexKVal]

It seems this is the cause why react-router sets react dependency that way: [email protected]

[dozoisch]

We should do the same since any react updates are pretty majors right now.

[AlexKVal]

I've found the culprit.
It is this line: "react": "*" package.json#L54

If I change it to "react": ">0.10.0" then everything is fine.

I've got a question before I can PR this change.
What is the minimal sufficient version of react here ?

[taion]

Should be 0.13.x I'd think?

[AlexKVal]

maybe for the benefit of safety >0.10.0 ?

though I presume those who has active React projects - in theory - has to update them already at least to 0.12

but we still can just for safety set it to >0.10.0

[mathieumg]

Theoretically, the lower that doesn't break it!

[catskul]

This has cropped up again

I'm not sure if it's somehow configuration dependent, but if I create a new directory, and attempt to install react-bootstrap locally I consistently get peerinvalid for all versions that I've tested (0.18, 0.19, HEAD) using npm 2.9.0

Example:

catskul$ npm install [email protected]
npm WARN package.json @ No description
npm WARN package.json @ No repository field.
npm WARN package.json @ No README data
npm WARN peerDependencies The peer dependency react-bootstrap@>=0.22.4 included from react-router-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-router@>=0.13.1 included from react-router-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency [email protected] included from react-router will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@>=0.14.0 included from react-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-dom@>=0.14.0 included from react-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@>=0.11.0 included from uncontrollable will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@>=0.14.0 included from react-overlays will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-dom@^0.14.0 included from react-overlays will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm ERR! Linux 3.16.0-44-generic
npm ERR! argv "/home/catskul/.nvm/versions/io.js/v2.0.2/bin/iojs" "/home/catskul/.nvm/versions/io.js/v2.0.2/bin/npm" "install" "[email protected]"
npm ERR! node v2.0.2
npm ERR! npm  v2.9.0
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package react does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants [email protected]
npm ERR! peerinvalid Peer [email protected] wants react@>=0.14.0

npm ERR! Please include the following file with any support request:
npm ERR!     /home/catskul/tmp/test-react-bootstrap/npm-debug.log

[taion]

You can see the error in your own logs:

npm ERR! peerinvalid Peer [email protected] wants [email protected]
npm ERR! peerinvalid Peer [email protected] wants react@>=0.14.0

And RRB v0.19.x requires a React Router v1.0.0 prerelease anyway.

[catskul]

Not sure I understand. How should installing a single package locally in a fresh local dir (no other installs done) ever create a peerinvalid error?

[taion]

You have two packages that require incompatible peer dependencies.

[catskul]

But they're pulled in by react-router-bootstrap. I did not specify those packages.

[taion]

Oh. I see. Unfortunately that's just NPM2's peer dependency handling for you - you'll need to explicitly specify React-Bootstrap v0.26.x.

[catskul]

that's just NPM2's peer dependency handling for you

Apparently something I've not yet discovered, but that certainly worked. Thanks! : )

Should react-router-bootstrap not itself include dependency information to prevent this situation from happening, or is it something that is not resolvable that way?

[taion]

We'd have to cut a new v0.18.x release that explicitly excluded React Bootstrap >= v0.27.0. I'm not sure that's worth the effort.