Comments (3)
Btw I'd be happy to submit a PR if you like.
from dnd-core.
I want the current drop result to be available in Store on each iteration. When I make that target.drop
call in the cycle, it might read from the Store.
I'm not super happy about it. While your second approach could work, I think the problem is me being lazy.
The correct approach would be to let context
be aware of the “ephemeral” drop target value so when we call target.drop(context)
, context.getDropResult()
inside it would return the work-in-progress result instead of reading it from the Store. After all such cases are the reason I hid direct Store access behind this context
proxy from user code.
When the loop is finished, we will dispatch exactly one drop
action. This sounds more solid.
from dnd-core.
I'm closing because we're going to drop Flummox anyway.
from dnd-core.
Related Issues (16)
- TODO HOT 3
- Expose higher-level Observable API HOT 1
- Flummox's Actions.js grabs all console logs HOT 1
- Tests involving Symbols currently failing HOT 1
- endDrop notification. HOT 1
- Drop action nulls dragOffsets HOT 1
- DragDropMonitor failes to notify subscribeToStateChange subscribers in some cases HOT 1
- Idea: Integrate With External Redux Store HOT 1
- TypeError: (0 , _dndCore2.default) is not a function HOT 3
- In Dnd-Core,HandlerRegistry is imported but not used in DragDropManager.js HOT 1
- `isOver` and `DropTarget` `hover` race condition
- Update to Babel 6
- Use eslint-config-airbnb
- How do we implement dragOver and coordinate tracking? HOT 3
- Be resilient against errors in hooks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dnd-core.