GithubHelp home page GithubHelp logo

Comments (3)

acdlite avatar acdlite commented on May 4, 2024

Btw I'd be happy to submit a PR if you like.

from dnd-core.

gaearon avatar gaearon commented on May 4, 2024

I want the current drop result to be available in Store on each iteration. When I make that target.drop call in the cycle, it might read from the Store.

I'm not super happy about it. While your second approach could work, I think the problem is me being lazy.

The correct approach would be to let context be aware of the “ephemeral” drop target value so when we call target.drop(context), context.getDropResult() inside it would return the work-in-progress result instead of reading it from the Store. After all such cases are the reason I hid direct Store access behind this context proxy from user code.

When the loop is finished, we will dispatch exactly one drop action. This sounds more solid.

from dnd-core.

gaearon avatar gaearon commented on May 4, 2024

I'm closing because we're going to drop Flummox anyway.

from dnd-core.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.