GithubHelp home page GithubHelp logo

Comments (9)

dhrrgn avatar dhrrgn commented on April 28, 2024

I will also note, just in case it means anything, that line is also called here (without issue): https://github.com/brentvatne/react-native-video/blob/master/RCTVideo.m#L99

from react-native-video.

stephenplusplus avatar stephenplusplus commented on April 28, 2024

I'm getting this as well. Have you found any workarounds?

from react-native-video.

brentvatne avatar brentvatne commented on April 28, 2024

cc @johanneslumpe

from react-native-video.

brentvatne avatar brentvatne commented on April 28, 2024

I think all we have to do here is add a try/catch block around [_playerItem removeObserver:self forKeyPath:statusKeyPath];, I'll try this out

from react-native-video.

johanneslumpe avatar johanneslumpe commented on April 28, 2024

@brentvatne Yeah we can try that, but I'm curious why this would happen in the first place. We might as well just set a flag when register for a notification on a player item. And in removeFromSuperView we can check whether the flag is set or not, and then we can act accordingly.

from react-native-video.

brentvatne avatar brentvatne commented on April 28, 2024

@johanneslumpe - sounds good to me, I'll do that now

from react-native-video.

brentvatne avatar brentvatne commented on April 28, 2024

Fixed in 0.4.1: c5eb6b4

@stephenplusplus @dhrrgn - give it a try and let me know if you still have the issue

from react-native-video.

johanneslumpe avatar johanneslumpe commented on April 28, 2024

πŸ‘

from react-native-video.

dhrrgn avatar dhrrgn commented on April 28, 2024

@brentvatne Works for me

from react-native-video.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.