GithubHelp home page GithubHelp logo

Comments (7)

brentvatne avatar brentvatne commented on April 27, 2024

Just to rule out the obvious, does the else condition in the parent ever render? If you remove the if entirely and just render that, does it work?

Could be a bug if that works.

from react-native-video.

wootwoot1234 avatar wootwoot1234 commented on April 27, 2024

It was working before I added the video code so yes. :(

I can double check when I get back to my computer in an hour.Β 

(null)

On Fri, Jun 19, 2015 at 3:23 PM, Brent Vatne [email protected]
wrote:

Just to rule out the obvious, does the else condition in the parent ever render? If you remove the if entirely and just render that, does it work?

Could be a bug if that works.

Reply to this email directly or view it on GitHub:
#58 (comment)

from react-native-video.

brentvatne avatar brentvatne commented on April 27, 2024

@wootwoot1234 - great thanks. If it is working, then if you can create an example repo where it is reproduced that would go a long way to helping me fix it!

from react-native-video.

wootwoot1234 avatar wootwoot1234 commented on April 27, 2024

@brentvatne Thanks for your help.

Here's a link to a repository with the bug.

https://github.com/wootwoot1234/VideoBugExample

Let me know if there is anything else I can do.

from react-native-video.

wootwoot1234 avatar wootwoot1234 commented on April 27, 2024

Any updates progress on this?

from react-native-video.

brentvatne avatar brentvatne commented on April 27, 2024

@wootwoot1234 - thank you so much for the example! That helps a lot. Confirmed that this is fixed in 0.4.6 - I pulled the project, ran it against 0.4.5, it was broken then updated to 0.4.6 and it works! This commit fixes it: a435efe

from react-native-video.

wootwoot1234 avatar wootwoot1234 commented on April 27, 2024

@brentvatne just updated it and it works great. Thanks!

from react-native-video.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.